Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version with py3 support #4

Closed
matthijskooijman opened this issue Aug 5, 2020 · 9 comments
Closed

Release new version with py3 support #4

matthijskooijman opened this issue Aug 5, 2020 · 9 comments

Comments

@matthijskooijman
Copy link

@matthijskooijman matthijskooijman commented Aug 5, 2020

I noticed that py3 support was added to master last month. Any chance this can be included in a new release soon? Debian is in the process of removing Python2, so without py3 support, OpenMSX will be removed in the near future. I might try backporting the py3 changes, but here have been some other build system changes, so I'm not sure if that will just work.

@matthijskooijman
Copy link
Author

@matthijskooijman matthijskooijman commented Aug 12, 2020

Probably still good to release, but for Debian I've ended up backporting 95ae612 and ffb7cb7 which together make the build work on Python3, so no more hurry from my side.

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Mar 2, 2021

Can you please specify which script files specifically are incompatible with Python 3 and why?

To me, it seems all Python scripts are compatible with Python 3 now; it builds just fine to me.

Also, I think it would make sense to treat “py3 support” and “release new version” as two separate issues.

@orudge
Copy link
Contributor

@orudge orudge commented Mar 2, 2021

To me, it seems all Python scripts are compatible with Python 3 now; it builds just fine to me.

Python 3 support was added in ffb7cb7

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Mar 2, 2021

I see, it seems this issue is actually just about making a release then.

In that case, I want to note that there are still a couple of things that should be fixed in OpenMSX, like the outdated build system with Mercirual references, or the outdated README file.

Speaking of releases, I suggest that when all problems in OpenMSX are fixed, go straight for version 1.0.0. OpenMSX has been de facto finished for years, there is no point in false humility. ;-)

@matthijskooijman
Copy link
Author

@matthijskooijman matthijskooijman commented Mar 2, 2021

I see, it seems this issue is actually just about making a release then.

Yup, py3 support is only the reason for wanting a release, not something left to fix :-)

In that case, I want to note that there are still a couple of things that should be fixed in OpenMSX, like the outdated build system with Mercirual references, or the outdated README file.

Per you own logic (which I agree with), these should probably be separate issues. Looking at the issue list, it seems you already created issues, so I guess your question really is: "Can we fix #5 and #6 before release?"

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Mar 2, 2021

I don't really mind if the release would be done without the other fixes, as long they will be fixed (and released) eventually. PRs are already in the pipeline for that, after all.

But a release without a functional up-to-date build scripting should probably not be 1.0.0.

@orudge
Copy link
Contributor

@orudge orudge commented Mar 2, 2021

You can't have a release until the build scripting is modernised, it's a prerequisite. :)

But given it has been done for OpenSFX, it shouldn't be hard to get it working for OpenMSX too. I'm a bit busy at the moment but when I get a chance I'll take a look at it if nobody's beaten me to it first. (Feel free to volunteer!)

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Mar 13, 2021

Concerning the build system: #7 #8

@LordAro
Copy link
Member

@LordAro LordAro commented Mar 23, 2021

Issue resolved. New release following shortly

@LordAro LordAro closed this as completed Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants