Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI File Fixes for Technical Errors #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

@curioustorvald
Copy link

@curioustorvald curioustorvald commented Oct 7, 2021

Related issue: #17

This commit fixes so-called "music is distorted but sometimes" bug observed on Windows, caused by some songs changing MIDI Pitch Bend ranges but it's not being reverted.

In other words, I just added bend range reset commands on every single MIDI file so that they are properly initialised.

Ideally this should be fixed by the sequencer itself — they should reset any parameter changes from previous songs — but it seems Windows MIDI sequencer doesn't do that, and since Microsoft actually fixing any music-related bugs on their product is simply something that would never happen, I thought it would be better to "fix" the MIDI file themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant