Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sounds for "unused" empty sounds? #18

Closed
Wuzzy2 opened this issue Feb 9, 2021 · 3 comments
Closed

Make sounds for "unused" empty sounds? #18

Wuzzy2 opened this issue Feb 9, 2021 · 3 comments

Comments

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Feb 9, 2021

Currently, there are two empty sounds in OpenSFX: osfx_34.wav (SND_22_CAR_HORN) and osfx_50.wav (SND_32_POP_2).

Those sounds are not used in OpenTTD so far (1.10.0), according to looking at the source code. (Here's an overview btw: https://wiki.openttd.org/en/Development/SoundIDs). So it is currently perfectly OK that both sounds are empty.

But would it make sense to create sound files for those two, just in case that support for OpenTTD is added later? It seems like the first one is meant for a car horn, and the second one is meant for an 'alternative' bubble pop sound for the Toyland bubble generator.

See also: OpenTTD/OpenTTD#8619

@frosch123
Copy link
Member

@frosch123 frosch123 commented Feb 9, 2021

NewGRF can add their own sounds.

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 9, 2021

You're sidestepping the issue. This is not about neccessarily inventing new sounds. It's about sound IDs that are OFFICIALLY defined in OpenTTD, but are currently unused for some reason. I also still have not gotten an answer on the other issue whether these sounds are really meant to be unused or if it's a bug/oversignt.
If these sound IDs are intentionally unused, then this issue is moot, and can be closed.
But if these sound IDs were meant to be actually used officially, just haven't been implemented for some reason, then I think this issue is valid.

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 19, 2021

So I was told the sounds are intentionally unused. This means this issue is now moot.

@Wuzzy2 Wuzzy2 closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants