Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations in 'lang' directory #21

Closed
Wuzzy2 opened this issue Feb 10, 2021 · 2 comments
Closed

Update translations in 'lang' directory #21

Wuzzy2 opened this issue Feb 10, 2021 · 2 comments

Comments

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Feb 10, 2021

Currently, in the lang directory, all languages still refer to the "CC Sampling Plus" license (which will soon be dropped in #14).

However, when the license is changed (in #14), this still leaves us with many langauges which still have the old wording, including the name "Samplinig Plus".

This is what english.lng will look like after #14:

OpenSFX sound replacement set for OpenTTD. Freely available under the terms of the following licenses: Creative Commons Attribution-ShareAlike 3.0 Unported, GNU General Public License version 2 (or later) and Common Development and Distribution License 1.1. Contains samples from "freesound.org" and "pdsound.org". For full credits see "readme.txt". [{TITLE}]

This is what english.lng looks like before #14:

OpenSFX sound replacement set for OpenTTD. Freely available under the terms of the Creative Commons Sampling Plus 1.0 License. Contains samples from "freesound.org" and "pdsound.org". For full credits see "readme.txt". [{TITLE}]

Now the question is, what to do with the translations? If #14 is merged, all translations are no longer valid, so they can no longer be used. The interesting part of the text change is "Creative Commons Attribution-ShareAlike 3.0 Unported, GNU General Public License version 2 (or later) and Common Development and Distribution License 1.1".

Here are some ideas on what to do with the translations:

  • Automatic replacement: Just blindly replace the license name and paste in the new license string. It sounds good on surface, but would not work in practice. This is because of stuff like "version 2 (or later)", or the word "and". If we had only one overall license, we might have gotten away with this. :-(
  • Remove all translation files and request translators to start over. This would wipe out ca. 40 translations.
  • Keep translation files, but move them to an "archived" directory for reference (until a real translation is made). This would still essentially reset all translations, but could be a little help for translators.
@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 19, 2021

Will be fixed in #14.

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 25, 2021

#14 is merged.

@Wuzzy2 Wuzzy2 closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant