Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten some description texts #22

Merged
merged 2 commits into from Feb 26, 2021
Merged

Shorten some description texts #22

merged 2 commits into from Feb 26, 2021

Conversation

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Feb 25, 2021

This is a simple PR for a few minor cleanup work in the text files, mainly about overlong lines.

This PR dos the following:

  1. It shortens the main OpenSFX description a bit because it's quite long (it mentions 3 license names in full).
  2. It shortens the lines in the license.txt and changelog.txt to avoid ugly overlong lines in the OpenTTD window.

The overlong lines in the readme.txt are NOT touched by this since they can't be really avoided (long URLs).

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 25, 2021

Alright, I've just decided to break the overlong lines in the readme.ptxt anyway. It turns out that all URLs neatly fit into a line.

This will make the text much more readable when viewed in-game. The horizontal scrollbar will be gone at the default window size.

Copy link
Contributor

@orudge orudge left a comment

The commits should be using the appropriate prefix ("Change:" etc). The line breaks seem reasonable, though I wonder if something like:

* "1sticky8" from "freesound.org"
    * Dumpster_Diving.wav
      https://freesound.org/people/1sticky8/sounds/78484/
* "Bidone" from "freesound.org"
    * Affen schreit.mp3
      https://freesound.org/people/Bidone/sounds/67361/
* Elaine Miller ("Miselaineous" at "freesound.org")
    * elaine-growl.wav
      https://freesound.org/people/Miselaineous/sounds/63668/

(and so on) would look better. I don't think we need the < > round the URL (that style is not used elsewhere in the file), and keeping them at the same indentation will save a bit of space visually.

docs/changelog.txt Outdated Show resolved Hide resolved
@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 26, 2021

OK, I did the requested cleanup and force-pushed.

orudge
orudge approved these changes Feb 26, 2021
@orudge orudge merged commit 7dd5f84 into OpenTTD:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants