Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Stop calling OpenSFX a 'replacement' #36

merged 1 commit into from Mar 17, 2021


Copy link

@Wuzzy2 Wuzzy2 commented Mar 17, 2021

Someone complained in IRC that OpenSFX/OpenMSX is called a 'replacement' which is severely underselling this base set. And I agree, it should not be called a 'replacement', it is perfectly valid in its own right.

This PR will change the description and README. Note the description file is changed again, which means the translations have to be reset (again). :-( Feel free to reject if you don't want to reset the translations.

Copy link

@nielsmh nielsmh commented Mar 17, 2021

The Danish and Swedish translations already do not call it a "replacement", simply a sound set, so they don't need to be updated.

The Norwegian Bokmål translation however does need to be amended.

orudge approved these changes Mar 17, 2021
Copy link

@orudge orudge left a comment

Seems reasonable enough to me.

@orudge orudge merged commit 5af2d98 into OpenTTD:master Mar 17, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants