Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all sounds derived from non-free sources #8

Merged
merged 3 commits into from Feb 3, 2021

Conversation

@Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Jan 26, 2021

This PR does two things:

  • First, it updates the README to improve the documentation of the source sounds (URL, author name, license)
  • Second, all sounds that were derived from non-free source sounds (CC Sampling Plus, CC BY-NC, unknown license) have been replaced with new sounds

Details

I have tried to make the new sounds more or less "close enough" to the previous version, whenever it made sense. An important rule I followed is to roughly keep the length of the old sound.

Sounds that were derived from clear free sources (CC0, CC BY, CC BY-SA) are not touched, with one exception: osfx_26.wav ("Bus start, pull away with horn").

You will notice that osfx_25.wav ("Bus start, pull away") sounds almost identical to the previous version. But it's actually not the same file. I simply used the source file file0375.mp3 (which is CC0'ed) and made my own editing, in order to get rid of Sampling Plus. I did this so I could then remake osfx_26.wav, which is the same sound, but with a horn. osfx_26.wav includes a new horn sound.

WIP

I am almost happy with the new sounds, but it might not be perfect. What still needs to be done is in-game testing. I might still change a few sounds a little if I discover problems.

PLEASE do review all the new sounds yourself and enjoy! :)
See the text file updates in this PR to see which sounds are new.

Phase 1

Note that this PR intentionally does not replace ALL sounds. Consider this PR to be "phase 1" of the "liberation" process. :D With this PR, many sounds are still CC Sampling Plus'ed (i.e. non-free).

For all sounds that are not be touched by this PR, those sounds were derived from free/libre sources or were created by OpenTTD contributors directly. I want to deal with these sounds in "Phase 2" (which might be a later PR). The only thing that prevents those sounds from being libre is the permission of the sound editors, i.e. the people who downloaded the original sounds from freesound.org, did a little editing for OpenSFX and contributed them. The ideal way to deal with those sounds is to gain permission from those sound editors to change the license (see #6). But if we won't get this permission, the sounds need to be re-done in order to get rid of the nasty Sampling Plus license.

@Wuzzy2 Wuzzy2 force-pushed the replace_phase_1 branch 2 times, most recently from 48d937f to 51f10be Jan 26, 2021
@mattkimber
Copy link

@mattkimber mattkimber commented Jan 26, 2021

My thoughts, things where there was a difference I thought worth noting:

  • Train in tunnel osfx05 misses the nice reverb from the original TTD sound (OpenSFX also doesn't have great reverb, although it has some). Perhaps this would be a good opportunity to improve it? Also both of the train sounds are quieter, and IMO osfx_04 would benefit from a little bit of motion sound on the end as per the original.
  • osfx_33 sounds better to me than the original.
  • osfx_37 sounds a bit artificial, like it was a signal generator rather than a real cow. (The OSFX sample could do with replacing though, it has extraneous noise and and obvious click)
  • osfx42 now has a bit too much of a "sci-fi" tone? I think the bottle pop is good, the lead-in tone needs something that's less of an obviously synthesised sound.
  • A technical issue - osfx_54 is clipped (the waveform is truncated). osfx_55 sounds nice!
  • osfx_59 (supersonic) is a huge improvement! The old one was clipped and had noticeable noise reduction artifacts, this is much better.
  • osfx_61 doesn't feel at the right phase of the flight, is there a more "takeoff" type sample available? The original TTD sample is quite different to OpenSFX, more of a turbofan whine, so there's some scope here to do something that doesn't have to sound the same IMO.
  • osfx_66 is a little longer than the original, not too much. There is an opportunity here, though - TTD had some nice "tropical" sounding bird samples, I feel the ones in OpenSFX are a little too "European". Not an essential change :)
  • osfx_69 sounds like it's from an RC plane, and has some bad reverb effects at the end and some random electrical noise at the start. This one I think needs a much better sample.
  • osfx_71 is an improvement IMO, I never liked OpenSFX's monorail though. The tail of this sound does feel a bit over-processed to me, it has a repeated modulation which is quite noticeable.
  • osfx_72 again a good replacement, but worth checking if there are some more tropical birds which could be used.

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Jan 26, 2021

Note I have force-pushed a couple of times and updated various sounds, so please check again.

  • osfx_05 now has a simple echo. Maybe not perfect yet, but still
  • I agree that osfx_61 still needs work, I don't like it either. I just totally forgot about it …
  • The cow sound (osfx_37) ... It didn't occur to me that this sound sounds "unnatural". It was a real cow.
  • I will look into osfx_54. But I'm afraid I have to throw away this sound :(
  • For the tropical birds (69 and 72) I used the "similar sounds" feature of Freesound.org. I believe it's even the same bird species than before! :D I don't want the birds to be too "prominent" either, just a simple background noise. Personally, I like those birds.
  • osfx_42 and osfx_43 are the toy factory sounds, and yes, they did not turn out well at all. It was my failed attempt at redoing the current OpenSFX sounds. The challenging part will be to make the sounds sync perfectly with the toy factory animation
  • osfx_69 is the toyland propeller plane sound, so it is intentionally "wacky". But maybe there's a better sound for that? Hmmm …

I also strong recommend to actually test the sounds in-game. OpenTTD seems to alter the volume of some of the sounds, and this can have a big impact.

@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Jan 27, 2021

Updated: osfx_61, osfx_54

@mattkimber
Copy link

@mattkimber mattkimber commented Feb 1, 2021

Ah yes, that makes a lot more sense as a Toyland sound. I wonder if there's a way to get a "clean" version without the extraneous sounds. (Are they different enough in tone that a spectral repair would work?)

The echo improves 5 a lot.

The difficulty sometimes with sounds is even with a real source, noise reduction and repair can remove enough to make things sound like a pure tone. OpenTTD can tolerate noisier samples because it's not doing too much with them; they're mostly just ambient sounds and not processed further into a mix where very clean originals are desirable.

@Wuzzy2 Wuzzy2 force-pushed the replace_phase_1 branch from 54e8c35 to d60066a Feb 2, 2021
@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 2, 2021

Updated toy factory sounds osfx_42 and osfx_43. This sound pack is now ready for re-review.

@Wuzzy2 Wuzzy2 force-pushed the replace_phase_1 branch from d60066a to 285f26f Feb 2, 2021
@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 2, 2021

I just replaced the railroad crossing sound osfx_14. It turned out the source sound was based on a non-free sound (-NC), so it had to be replaced. The previous sound was a bit low-quality anyway (noise).

Copy link
Contributor

@orudge orudge left a comment

While I haven't reproduced every sound in-game, I have listed to all the modified sounds and checked over the readme/.sfo changes you've made and I'd say they look (sound) good to me.

You may wish to add yourself to the "Sound editors" section though, @Wuzzy2, since you have edited various sounds now.

I would also ask that you re-title your commits in the standard OpenTTD way - e.g., "Change: Replace all sounds...", and so on.

@Wuzzy2 Wuzzy2 force-pushed the replace_phase_1 branch from 285f26f to faed80c Feb 3, 2021
@Wuzzy2
Copy link
Contributor Author

@Wuzzy2 Wuzzy2 commented Feb 3, 2021

Okay, I added myself to the credits and change the commit names. Anything else?

@Wuzzy2 Wuzzy2 force-pushed the replace_phase_1 branch from faed80c to 37a1776 Feb 3, 2021
orudge
orudge approved these changes Feb 3, 2021
Copy link
Contributor

@orudge orudge left a comment

Thanks for your effort in helping to sort this!

@orudge orudge merged commit 64dad3c into OpenTTD:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants