Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: GIT_DIR is no longer set in git >= 2.18.0 #11

Merged
merged 1 commit into from Feb 23, 2020

Conversation

@xdavidwu
Copy link
Contributor

xdavidwu commented Jan 14, 2020

Use git rev-parse --git-dir as fallback.
Related discussion:
https://public-inbox.org/git/20180826004150.GA31168@sigill.intra.peff.net/t/

Use `git rev-parse --git-dir` as fallback.
Related discussion:
https://public-inbox.org/git/20180826004150.GA31168@sigill.intra.peff.net/t/
@glx22
glx22 approved these changes Jan 23, 2020
Copy link
Contributor

glx22 left a comment

Seems to be the right thing to do

@PeterN
Copy link
Member

PeterN commented Jan 26, 2020

As the safety-test condition relies on this variable being set, and we now set it ourselves, the safety check is no longer valid.

EDIT: Ah, but outside a git repo the variable is set to empty, so the condition still holds. Ignore me!

@glx22 glx22 merged commit 07f936d into OpenTTD:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.