Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check ObjC files as other source files #14

Merged
merged 1 commit into from Oct 3, 2020
Merged

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Oct 2, 2020

NFO files used for nml regression check can contain trailing whitespaces, and commit checker doesn't know that. This PR disable trailing whitespaces checks for these files.

Also, while reading the diff checker, I noticed ObjC source files of OpenTTD were skipped for most code style checks, so I fixed it.

@glx22 glx22 changed the title Whitespaces Commit checker improvements Oct 2, 2020
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Oct 2, 2020

You explain what this fixes, but not why this route. Why not fix the NFO files not to have the white space the checker triggers on?

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Oct 2, 2020

NFO files are generated by nml, and I don't think it's easy to not output extra spaces there.

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Oct 2, 2020

Sounds like this is a bug in NML and should be fixed there. I have a hard time believing stripping trailing whitespaces is difficult tbh :p

@glx22
Copy link
Contributor Author

@glx22 glx22 commented Oct 2, 2020

Yeah seems it was easier than I though (see OpenTTD/nml#164). I'll remove the first commit.

@glx22 glx22 force-pushed the glx22:whitespaces branch from 29aaf86 to fab3876 Oct 2, 2020
@glx22 glx22 changed the title Commit checker improvements Fix: Check ObjC files as other source files Oct 2, 2020
@LordAro
LordAro approved these changes Oct 3, 2020
@LordAro LordAro merged commit c7a7508 into OpenTTD:master Oct 3, 2020
@glx22 glx22 deleted the glx22:whitespaces branch Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants