Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Allow multiple #<issue>s without additional prefixes. #9

Closed

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented Feb 2, 2019

Allow commits in the form "Fix #, #: "

@@ -10,6 +10,7 @@
MSG_PAT2 = re.compile(KEYWORDS + " " + ISSUE + "$")
MSG_PAT3 = re.compile(KEYWORDS + " " + COMMIT + "$")
MSG_PAT4 = re.compile(COMMIT + "$")
MSG_PAT5 = re.compile(ISSUE + "$")

ERROR = """
*** First line of message must match: '<keyword>( #<issue>| <commit>(, (<keyword> #<issue>|<commit>))*)?: ([<section])? <Details>'
Copy link
Contributor

@glx22 glx22 Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update error message

@@ -10,6 +10,7 @@
MSG_PAT2 = re.compile(KEYWORDS + " " + ISSUE + "$")
MSG_PAT3 = re.compile(KEYWORDS + " " + COMMIT + "$")
MSG_PAT4 = re.compile(COMMIT + "$")
MSG_PAT5 = re.compile(ISSUE + "$")

ERROR = """
*** First line of message must match: '<keyword>( #<issue>| <commit>(, (<keyword> #<issue>|<commit>))*)?: ([<section])? <Details>'
Copy link
Contributor

@glx22 glx22 Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*** First line of message must match: '<keyword>( #<issue>| <commit>(, (<keyword> #<issue>|<commit>))*)?: ([<section])? <Details>'
*** First line of message must match: '<keyword>( #<issue>| <commit>(, ([<keyword> ]#<issue>|<commit>))*)?: ([<section>])? <Details>'

@PeterN PeterN closed this Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants