[Patch] removing most of the >> as / related to Money values

[DorpsGek]

Noldo opened the ticket and wrote:

As a side product of trying to make Money into class I ran into ">> 4" and similar ones applied to values of type Money. I feel that these should be changed to use / because it's more natural way for a human to read and also having a bit shift operator on a class that is an abstraction of money later doesn't seem to fit.

Attachments

• moneyrelatedclen_10963.diff (21.18 KiB)

Reported version: trunk
Operating system: All

---

This issue was imported from FlySpray: https://bugs.openttd.org/task/1149

[DorpsGek]

Noldo wrote:

Updated a bit after comments from peter1138.
Also fixed few things caused by overeagerness to remove bitshifts.

Attachments

• moneyrelatedclen_10963v2.diff (0.05 KiB)

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1149#comment1937

[DorpsGek]

Noldo wrote:

Lynx is not my friend.

Attachments

• moneyrelatedclean_10963v2.diff (20.75 KiB)

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1149#comment1938

[DorpsGek]

Noldo wrote:

Now with correct number of spaces.

Attachments

• moneyrelatedclean_10974.diff (21.55 KiB)

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1149#comment1957

[DorpsGek]

Noldo wrote:

Unified vehicle gui required a reaction.

Attachments

• moneyrelatedclean_11015.diff (19.56 KiB)

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1149#comment2012

[DorpsGek]

TrueBrain wrote:

Although the patch in fact looks nice, I don't see the usage of converting all the >> to /. It only tempt people to use non-power-of-two values, which will cause big slowdowns. For that reason, this patch is rejected for now. Who knows it will ever be applied, but currently there is no real gain, only a step back.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1149#comment2594

[DorpsGek]

TrueBrain closed the ticket.

Reason for closing: Won't implement

Patch rejected. Currently no real gain.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1149