assertion during re-connect when server restarted

[DorpsGek]

planetmaker opened the ticket and wrote:

On January 12 my client (beta2) crashed to the desktop during re-connect with an assertion failure when dihedral's server 3 restared as scheduled. A core dump is also available, if required.

Attachments

• crash_dih.txt (6.45 KiB)

Reported version: 0.6.0-beta1
Operating system: Windows

---

This issue was imported from FlySpray: https://bugs.openttd.org/task/1650

[DorpsGek]

glx wrote:

Please attach crash.dmp.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3243

[DorpsGek]

planetmaker wrote:

crash.dmp related to it.

Attachments

• crash.dmp (1341.75 KiB)

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3252

[DorpsGek]

glx wrote:

It is a forced crash after displaying "Trying to execute a packet in the past!" in console.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3260

[DorpsGek]

Rubidium wrote:

Is this in any way reproduceable because I cannot found anything 'wrong' with the code.

The client would've been disconnected from the server while downloading because all connections are destroyed. Then the client would reconnect, but during the reconnect the queue of commands would be emptied. Furthermore the client can only join once the frame counter and friends are reset.

That's basically making none of the join scenarios a way to reproduce this issue.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3271

[DorpsGek]

SmatZ wrote:

Maybe there is a packet in the packet queue. When the connection is lost, the packects in the queue are not erased.
Then, when starting NetworkGameLoop again, it loads the packet from previous game. It has higher packet number, so the game asserts.

Only theory, I haven't looked into the code.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3440

[DorpsGek]

planetmaker wrote:

A few days ago (sorry, don't have crash report there), a probably similar (same?) thing happened. OTTD exited with a message along the lines "old data packet received". Previously I had tried several times to connect to that server unsucessfully. The reason for the unsuccessful login attempts propably are a combination of slow(er) hardware and monstrously big and train-overloaded game (was on ottdcoop with ~1000 trains with 1024^2 map).
IMO this kinda supports SmatZ view.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3468

[DorpsGek]

SmatZ closed the ticket.

Reason for closing: Fixed

In r12367

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/1650