Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console: heightmaps for dedicated server #2155

Closed
DorpsGek opened this issue Jul 20, 2008 · 7 comments
Closed

Console: heightmaps for dedicated server #2155

DorpsGek opened this issue Jul 20, 2008 · 7 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Jul 20, 2008

Progman opened the ticket and wrote:

r13734

It is possible to generate a map on start of the dedicated server with a specific seed via -G, and you can load a game with -g. But its not possible to load a heightmap and let the server generate the cities and industries on it, althought a normal client can do it. So I request a feature which allowes a dedicated server to generate a map based on a heightmap.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2155
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Sep 14, 2012

Der_Herr wrote:

I attached a patch to enable a server to load heightmaps via console.

This patch is closely derived from the "newgame" console command with only small deviations.

It accepts bitmaps or pngs in the heightmap folder.

You can use the command like

a) newheightmapgame Test.bmp

this loads the heightmap from $OpenttdFolder/scenario/heightmap/Test.bmp

b) newheightmapgame

It works also on servers: rcon pw "newheightmapgame Test.bmp"

This answer is related to the forum post: http://www.tt-forums.net/viewtopic.php?f=33&t=62677

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2155#comment11507
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Sep 14, 2012

Yexo wrote:

Commented a bit too much on irc, adding it here so it doesn't get lost:

some comments: please check your comments for correctness / english: "Get heightmap file informations. It Only considers given paths."
GetFiosHeightmapItem <- I don't think that function belongs in console_cmds.cpp but rather in fios.cpp or something similar
+DEF_CONSOLE_CMD(ConNewHeightmapGame) <- comments above that are // style, not /** style like required
IConsoleHelp("Start a new gameusing a heightmap <- missing space
two lines further down the lines in the if-block are not indented properly
+ //StartNewHeightMapGameWithoutGUI((argc == 2) ? <- don't add commented-out code
+ IConsoleCmdRegister("newheightmapgame", ConNewHeightmapGame); <- only tabs at the beginning of the line, use spaces in all other places
how does this function behave when you're in the scenario editor?


This comment was imported from FlySpray: https://bugs.openttd.org/task/2155#comment11508
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Sep 14, 2012

Der_Herr wrote:

I think i fixed all your points refering to the style.
The function works fine in scenario editor.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2155#comment11509
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Sep 15, 2012

Der_Herr wrote:

I think i fixed all your points refering to the style.
The function works fine in scenario editor.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/2155#comment11510
@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 5, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

@LordAro

This comment has been minimized.

Copy link
Member

@LordAro LordAro commented Jan 12, 2019

Doesn't apply cleanly, but I think it'd be a nice consistent feature to have. Patch ultimately isn't all that complex, so probably wouldn't be difficult to update

@LordAro LordAro removed the stale label Jan 12, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Feb 26, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Mar 1, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Mar 2, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Mar 2, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Mar 2, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Mar 3, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Mar 5, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Mar 6, 2019
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Mar 13, 2019
@stale stale bot closed this Mar 20, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Apr 10, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue May 14, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Aug 3, 2019
Berbe added a commit to Berbe/OpenTTD that referenced this issue Feb 10, 2020
Berbe added a commit to Berbe/OpenTTD that referenced this issue Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.