connection lost messages for every disconnect

[DorpsGek]

dihedral opened the ticket and wrote:

the 'connection lost' message ALWAYS appears after any type of disconnect.
may it be a kick or leaving the game normally.

i have also found out that NetworkCloseClient() is called twice, once for leaving, and once from NetworkClientSocket::CloseConnection() (in src/network/core/tcp_game.cpp)

*** Mr. Twisty22 has left the game (leaving)
*** Mr. Twisty22 has left the game (connection lost)

my logs show this behavior since r15985, however r15966 was not able to be tested correctly due to a bunch of crashes. the last nightly with normal behavior was r15964

Reported version: trunk
Operating system: All

---

This issue was imported from FlySpray: https://bugs.openttd.org/task/2880

[DorpsGek]

dihedral wrote:

only fixed for client quit, not for kick or ban

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/2880#comment6245

[DorpsGek]

dihedral wrote:

perhaps if the same line is added to sending PACKET_SERVER_ERROR ?

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/2880#comment6246

[DorpsGek]

Rubidium closed the ticket.

Reason for closing: Fixed

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/2880