Copy dedicated server console output to file is broken

[DorpsGek]

dolly opened the ticket and wrote:

Copying console output of dedicated server to file (IConsoleWriteToLogFile) is broken (only zero length file is created and "cannot write to log file" error displayed) unless _settings_client.gui.show_date_in_logs is set to true.

Reported version: 1.0.0-RC1
Operating system: All

---

This issue was imported from FlySpray: https://bugs.openttd.org/task/3639

[DorpsGek]

Rubidium wrote:

What OS is used? It seems to work fine for me.

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/3639#comment7620

[DorpsGek]

dolly wrote:

Tested on windows 7 and windows vista. This is relevant part from console window (transcript.log was created, but is zero sized)...

dbg: [net] Map generation percentage complete: 90
dbg: [net] Map generation percentage complete: 95
dbg: [net] Map generated, starting game
script transcript.log
file output started to: transcript.log
dbg: [net] [udp] queried from 192.168.180.151
dbg: [net] [udp] queried from 192.168.180.151
dbg: [net] Client connected from 192.168.180.151 on frame 903
dbg: [net] Closed client connection 2
dbg: [net] Client connected from 192.168.180.151 on frame 973
*** Game paused (connecting clients)
cannot write to log file
*** Tst # 1 has joined the game (Client # 3)
*** Game unpaused (connecting clients)
dbg: [net] recv failed with error 10054
*** Tst # 1 has left the game (connection lost)
dbg: [net] Closed client connection 3

The problem seems to be in IConsoleWriteToLogFile.

  const char *header = GetLogPrefix();
  if (fwrite(header, strlen(header), 1, _iconsole_output_file) != 1 ||

GetLogPrefix() returns \0
and next fwrite returns 0

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/3639#comment7621

[DorpsGek]

Rubidium wrote:

Does the attached diff fix the issue?

Attachments

• fs3639.diff (0.64 KiB)

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/3639#comment7624

[DorpsGek]

dolly wrote:

yes, this fixes it

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/3639#comment7626

[DorpsGek]

Rubidium closed the ticket.

Reason for closing: Deferred

In r19252

---

This comment was imported from FlySpray: https://bugs.openttd.org/task/3639