Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADMIN_PACKET_SERVER_CLIENT_ERROR not sent when client loses connection #4585

Closed
DorpsGek opened this issue Apr 9, 2011 · 3 comments
Closed
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 9, 2011

yorick opened the ticket and wrote:

When a client loses connection, any connected admins are not notified about the error, which leaves them unable to find out that the client is no longer there without nonautomatic updates or console forwarding. Further investigation revealed that "NetworkAdminClientError(this->client_id, NETWORK_ERROR_CONNECTION_LOST);" is missing from ServerNetworkGameSocketHandler::CloseConnection.

Reported version: 1.1.0
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4585
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r22384


This comment was imported from FlySpray: https://bugs.openttd.org/task/4585

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2011

xOR wrote:

the fix is in trunk but was also listed on the changelog for 1.1.1-RC1, yet didn't go into the 1.1.1 release. just noting it here so others don't do the same like me: search the bug in their program for an hour just to notice that it's OpenTTD which simply isn't sending the packet :(


This comment was imported from FlySpray: https://bugs.openttd.org/task/4585#comment10042

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 2, 2011

frosch wrote:

confirmed, readded for 1.1.2-RC1


This comment was imported from FlySpray: https://bugs.openttd.org/task/4585#comment10044

@DorpsGek DorpsGek added Admin flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant