Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shift to estimate costs only with a certain type of commands #4684

Closed
DorpsGek opened this issue Jul 13, 2011 · 3 comments
Closed

Use shift to estimate costs only with a certain type of commands #4684

DorpsGek opened this issue Jul 13, 2011 · 3 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Jul 13, 2011

adf88 opened the ticket and wrote:

This patch makes the shift key more usable by narrowing the set of commands in which we can estimate costs.

For the set I chose CMDT_LANDSCAPE_CONSTRUCTION and CMDT_VEHICLE_CONSTRUCTION commands. These are the only commands that costs us money and after firing them we can see on the map a floating price drawn red (this rule is very clear). Other commands that have to do with our money are CMDT_MONEY_MANAGEMENT, but these are actually costless and cost estimation returns 0 anyway (and we can't see a floating price drawn red after firing them).

The patch is related to (it's a suggestion to) FS4668

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4684
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Mar 14, 2017

peter1138 wrote:

Doesn't this break a usability rule that pressing shift will not actually execute anything?


This comment was imported from FlySpray: https://bugs.openttd.org/task/4684#comment14382
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Apr 2, 2017

adf88 wrote:

No, because there is no such rule i.e. shift-clicking on jukebox "play" button WILL execute the action.

The patch narrows the affected area from "actions that change game state" to "actions that involve buying/building something".


This comment was imported from FlySpray: https://bugs.openttd.org/task/4684#comment14407
@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 5, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.