Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals: signal window - show one signal variant at a time #5735

Closed
DorpsGek opened this issue Sep 4, 2013 · 5 comments
Closed

Signals: signal window - show one signal variant at a time #5735

DorpsGek opened this issue Sep 4, 2013 · 5 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Sep 4, 2013

adf88 opened the ticket and wrote:

Basic idea of the patch is not to show all signal variant/type combinations in the signal window. Instead there is separate switch for signal variant (semaphore/electric) and separate switch to choose signal type. New signal window also fits better to different sizes of sprites and fonts, distinct GUI elements are being resized independently.

Requires patches from #5733
http://bugs.openttd.org/task/5733/getfile/9327/10-fit-signal-gui-to-signal-sprites.diff
http://bugs.openttd.org/task/5733/getfile/9328/11-fit-signal-gui-to-density-text.diff

The patch (against r25753) and some screenshots attached.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5735
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Aug 13, 2017

andythenorth wrote:

I would prefer this UI. The signal UI is over-loaded with buttons imho. Also I don't use semaphore signals, so that row of buttons is just visual noise to me :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5735#comment14511
@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Jul 23, 2018

IMO some additional separation between block and path signals would be appropriate, possibly even with labels for each type.
Would it be blasphemy to separate out one-way and two-way standard block signals, instead of the classic tri-state rotation by clicking on the signals?

@andythenorth andythenorth added the stale label Jan 5, 2019
@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 5, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 12, 2019

Discussed on irc, this is a wanted feature, but no current interest, so closing. Possible to re-open in future. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.