Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No wait cursor while autosaving #5872

Closed
DorpsGek opened this issue Jan 23, 2014 · 6 comments
Closed

No wait cursor while autosaving #5872

DorpsGek opened this issue Jan 23, 2014 · 6 comments
Labels

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Jan 23, 2014

MJP opened the ticket and wrote:

The following patch depends on the issue of #5871.
I'd like to remove the wait cursor set each time a threaded autosave occurs.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5872
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Mar 9, 2014

LordAro wrote:

Coding style issues - if {} else if {} blocks always get braces and go on their own lines


This comment was imported from FlySpray: https://bugs.openttd.org/task/5872#comment13135
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Sep 9, 2017

Alberth wrote:

Misses the case where thread starting fails and reverting back to non-threading.

Also, afaik (but never checked), Zzz cursor is only shown while copying the map in memory, which is a valid period since literally nobody can change the map during that time. Actual saving the data to disk should be without Zzz cursor, I think.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5872#comment14763
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Feb 3, 2018

Samu wrote:

I also dislike the zzzz cursor showing up of nowhere because of autosave when I'm in the middle of building something.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5872#comment14843
@TrueBrain

This comment has been minimized.

Copy link
Member

@TrueBrain TrueBrain commented Apr 11, 2018

The Zzz is shown from the start of storing the file on disk, till it finishes. So basically after the map has been stored in memory to be saved :)

What I do like about Zzz that it is a reminder that auto-save happened. But possibly there is a better way to give that visual feedback. I prefer that above simply removing it. A chat text? An icon in the top-right corner? (otherwise we have a new ticket in no time people complaining they don't see that autosave happened :P)

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 5, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 12, 2019

As TrueBrain says, this isn't just 'check patch applies, test, commit'. This one has bigger UI / experience implications. So closing, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.