Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify appearance and position of location buttons (wanted contributions-list) #5981

Closed
DorpsGek opened this issue Apr 12, 2014 · 5 comments
Closed

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Apr 12, 2014

talebowl opened the ticket and wrote:

This patch unifies the appearance and the position of the location buttons in Town view, Industry view, Depot view, Station view, Waypoint view by adding a button to the right side of the top-of-the-window-bar. Because the other buttons were removed, the "Location" button string (STR_BUTTON_LOCATION) was removed from all language files, as the wiki details.

New goto location buttons were added in: Error messages (where suitable (those with a position attribute)), LandArea/Tile info window, City Authority/Council window.

The forum post related to this item ( http://www.tt-forums.net/viewtopic.php?f=32&t=64539&p=1116910 ) also suggested a location button in the city rename window, but I thought that would be overkill (especially as the window is not one that would stay open for long). If needed, I can still add that, though.

The patch also adds an icon to the baseset format.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5981
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Sep 2, 2017

andythenorth wrote:

This is in the official list of 'wanted patches' per https://wiki.openttd.org/Todo_list


This comment was imported from FlySpray: https://bugs.openttd.org/task/5981#comment14723
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Sep 2, 2017

andythenorth wrote:

If this had screenshots, it might be more likely to get looked at.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5981#comment14724
@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 6, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 6, 2019

At minimum this is going to need conflicts resolved in openttdgui.png, so I will be surprised if this goes further.

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 12, 2019

Closing this one, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.