Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commuter - Helicopter is in flight bug #6219

Closed
DorpsGek opened this issue Jan 24, 2015 · 5 comments
Closed

Commuter - Helicopter is in flight bug #6219

DorpsGek opened this issue Jan 24, 2015 · 5 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Jan 24, 2015

Samu opened the ticket and wrote:

Quick way to reproduce the bug is by having no means to have cargo waiting at the commuter

  1. Build a commuter near nothing.
  2. Build 3 helicopters and full load at the commuter.
  3. Start all 3 helicopters.

The 3rd helicopter will be bugged inside hangar and cannot be stopped. It says it is in flight. For this to happen, the 2 helipads must be busy.

Another bug, continuing the steps.
4) Send the first helicopter to hangar.

The 3rd helicopter is not heading to the free helipad.

Yet another bug, continuing.
5) Send the second helicopter to hangar.

The 2nd helicopter and 3rd helicopter will go through each other head on.

Attachments

Reported version: 1.5.0-beta1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6219
@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Jan 24, 2015

Samu wrote:

Savegame

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6219#comment13740

@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Jan 24, 2015

Samu wrote:

Sorry, that savegame shows nothing, and the steps are missing something.

Trying again:

  1. Build 2 airports, one is commuter, the other is a random one
  2. Build 3 helicopters at the commuter
  3. Order the 3 helicopters to full load at the commuter as order 1
  4. Order the 3 helicopters to go to the random airport as order 2
  5. Order Helicopter 3 to skip to order 2
  6. Start Helicopter 1 and 2 first, then start 3 shortly after.

The 3rd helicopter will be bugged inside hangar and cannot be stopped. It says it is in flight. For this to happen, the 2 helipads must be busy.

Another bug, continuing the steps.
7) Send the first helicopter to hangar.

The 3rd helicopter is not heading to the free helipad.

Yet another bug, continuing.
8) Send the second helicopter to hangar.

The 2nd helicopter and 3rd helicopter will go through each other head on.

I've attached another savegame.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6219#comment13741

@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Feb 1, 2015

Alberth wrote:

Save game shows commuter airport with 2 helicopters loading, and the 3rd helicopter in the hangar "heading to foo airport".

  1. While 3rd helicopter is still in the hangar, it's considered to be "en route", stopping is not possible.

At the other airport, one can stop helicopter while taxiing or on the runway. It looks like stopping was omitted at the commuter. Aircraft can be stopped as well at the commuter.

  1. Click the rightmost helicopter, and let it return to the hangar. Helicopter 3 in the hangar does not pick up this change, and stays in the hangar.
    This also happens when the rightmost helicopter leaves the airport.

  2. Click the leftmost helicopter, and let it return to the hangar. Helicopter 3 is released too early, and both helicopters cross each other in front of the hangar.

If you let one helicopter from the hangar return to the leftmost loading spot, and then release the second one, the rightmost empty position is noticed.

Conclusions about the commuter airport:
- Stopping of helicopters seems broken or not implemented.
- Selection of free helipads from the hangar does not notice the right-most pad getting empty if it is initially claimed.
- Block in front of the hangar is released too early by helicopter returning to the hangar from the leftmost position (and perhaps also the rightmost position).


This comment was imported from FlySpray: https://bugs.openttd.org/task/6219#comment13750

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Nov 5, 2018

Possibly aircraft control logic should be entirely changed to use a separate "is_airborne" flag rather than the current state checks, similar to what I'm doing in #6962. The flag should then be set when an aircraft begins take-off, and be cleared when it finishes landing.

@stale
Copy link

@stale stale bot commented Jan 24, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Jan 24, 2019
@LordAro LordAro added pinned and removed stale labels Jan 24, 2019
JMcKiern added a commit to JMcKiern/OpenTTD that referenced this issue Aug 30, 2019
Previously, a helicopter in the hangar of a commuter airport would have to wait until HELIPAD2 was free before it could takeoff. Now, a helicopter in the hangar can takeoff from just outside the hangar.
JMcKiern added a commit to JMcKiern/OpenTTD that referenced this issue Sep 2, 2019
Previously, a helicopter in the hangar of a commuter airport would have to wait until HELIPAD2 was free before it could takeoff. Now, a helicopter in the hangar can takeoff from just outside the hangar.
@nielsmh nielsmh closed this in d843b73 Oct 25, 2019
douiwby added a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
Previously, a helicopter in the hangar of a commuter airport would have to wait until HELIPAD2 was free before it could takeoff. Now, a helicopter in the hangar can takeoff from just outside the hangar.
spnda added a commit to spnda/OpenTTD that referenced this issue Jun 17, 2020
Previously, a helicopter in the hangar of a commuter airport would have to wait until HELIPAD2 was free before it could takeoff. Now, a helicopter in the hangar can takeoff from just outside the hangar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants