Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helicopters do not autorenew/autoreplace while in routes consisting of heliports #6493

Closed
DorpsGek opened this issue Aug 6, 2016 · 4 comments
Closed
Labels

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Aug 6, 2016

juanjo opened the ticket and wrote:

(r27616)
Helicopters are serviced each time they take off from an helipad/heliport, but do not autorenew or autoreplace on helipads.
Old helicopters with routes involving only heliports (no hangars) are not headed to an airport with a hangar when they need autorenewing or autoreplacing.

By the way, the DEPOT_LOCATE_HANGAR flag is currently unused.

Attachments

Reported version: Version?
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6493
@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Aug 7, 2016

frosch wrote:

The code for DEPOT_LOCATE_HANGAR apparently got lost in r12658.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6493#comment14248

@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Mar 14, 2017

peter1138 wrote:

Only rarely. It's mainly because when the serviceathelipad setting is enabled, helicopters are never eligible for autorenew/autoreplace as they have always just been serviced by the time the helicopter takes off.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6493#comment14384

@frosch123 frosch123 removed the Core label Apr 14, 2018
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 2, 2018
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 2, 2018
…d or when no_servicing_if_no_breakdowns is disabled

Helicopters with 'service at helipads' enabled, will only do so when 'disable servicing when servicing set to none' is disabled, or, if enabled, when 'vehicle breakdowns' is not set to none.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 2, 2018
…pending replace

Check if an airplane needs automatic servicing or if a helicopter has a pending replace and send it to hangar before sending to takeoff

This replaces the old method which was attempting to do the same, but was ultimately canceling automatic servicing orders upon landing.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 5, 2018
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 5, 2018
…d or when no_servicing_if_no_breakdowns is disabled

Helicopters with 'service at helipads' enabled, will only do so when 'disable servicing when servicing set to none' is disabled, or, if enabled, when 'vehicle breakdowns' is not set to none.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 5, 2018
…pending replace

Check if an airplane needs automatic servicing or if a helicopter has a pending replace and send it to hangar before sending to takeoff

This replaces the old method which was attempting to do the same, but was ultimately canceling automatic servicing orders upon landing.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
…d or when no_servicing_if_no_breakdowns is disabled

Helicopters with 'service at helipads' enabled, will only do so when 'disable servicing when servicing set to none' is disabled, or, if enabled, when 'vehicle breakdowns' is not set to none.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
…pending replace

Check if an airplane needs automatic servicing or if a helicopter has a pending replace and send it to hangar before sending to takeoff

This replaces the old method which was attempting to do the same, but was ultimately canceling automatic servicing orders upon landing.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
…d or when no_servicing_if_no_breakdowns is disabled

Helicopters with 'service at helipads' enabled, will only do so when 'disable servicing when servicing set to none' is disabled, or, if enabled, when 'vehicle breakdowns' is not set to none.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
…pending replace

Check if an airplane needs automatic servicing or if a helicopter has a pending replace and send it to hangar before sending to takeoff

This replaces the old method which was attempting to do the same, but was ultimately canceling automatic servicing orders upon landing.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 12, 2019
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 12, 2019
…d or when no_servicing_if_no_breakdowns is disabled

Helicopters with 'service at helipads' enabled, will only do so when 'disable servicing when servicing set to none' is disabled, or, if enabled, when 'vehicle breakdowns' is not set to none.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 12, 2019
…pending replace

Check if an airplane needs automatic servicing or if a helicopter has a pending replace and send it to hangar before sending to takeoff

This replaces the old method which was attempting to do the same, but was ultimately canceling automatic servicing orders upon landing.
@stale
Copy link

@stale stale bot commented Jan 24, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Jan 24, 2019
@LordAro LordAro added pinned and removed stale labels Jan 24, 2019
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 26, 2019
…d or when no_servicing_if_no_breakdowns is disabled

Helicopters with 'service at helipads' enabled, will only do so when 'disable servicing when breakdowns set to none' is disabled, or, if enabled, when 'vehicle breakdowns' is not set to none.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 26, 2019
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 26, 2019
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
@nielsmh nielsmh removed the bug label Jan 27, 2019
@nielsmh nielsmh removed the pinned label Jan 27, 2019
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jan 27, 2019

This is not an actual problem. The serviceathelipad setting exists in OpenTTD because it was implemented in TTDPatch at the dawn of time, and its only purpose was to make helipad-only routes somewhat viable when helistations with hangars did not yet exist. Now helistations do exist, and thus the setting is pretty much pointless.

Closing as not a bug.

@nielsmh nielsmh closed this Jan 27, 2019
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Apr 14, 2019
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Dec 30, 2019
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 3, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 8, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 8, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 11, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 11, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 11, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 12, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 19, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 6, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 23, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 23, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 24, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 29, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 13, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Apr 1, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Dec 25, 2020
…ft at a hangar outside the order list

If a helicopter needs to be sent to a hangar during automatic service, and there are no airports with hangars in the orders (travelling between heliports), a nearby hangar outside the orders will be searched. If the distance to a found hangar is shorter than the distance to the helistation/airport the helicopter is headed to, the helicopter is sent to that hangar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants