Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buoys can prevent oil rig spawns #6548

Closed
DorpsGek opened this issue Mar 25, 2017 · 7 comments
Closed

Buoys can prevent oil rig spawns #6548

DorpsGek opened this issue Mar 25, 2017 · 7 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Mar 25, 2017

Samu opened the ticket and wrote:

When an oil rig is spawning, the special water check require that the tile is of type water. Ship Depots and Locks are tiles of type water and won't prevent oil rig from spawning. Buoys, however, are of tile type station, and are preventing oil rigs from spawning.

This patch should allow it to spawn when checking for water nearby on buoys as well.

Attachments

Reported version: 1.7.0-RC1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6548
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Mar 25, 2017

Samu wrote:

My bad, made a bool mistake, this patch should do what I was intending.

EDIT: now with parentesis. Use v3.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14402
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Apr 1, 2017

peter1138 wrote:

Arguably the check should be extended the other way so that depots and locks are excluded?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14405
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Apr 3, 2017

peter1138 wrote:

Ok, so now depots and locks aren't considered clear... does it make sense that buoys should be? I think probably not.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14415
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Aug 23, 2017

andythenorth wrote:

If we're changing this, I would consider depots and locks not clear. Also buoys not clear.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6548#comment14624
@TrueBrain

This comment has been minimized.

Copy link
Member

@TrueBrain TrueBrain commented Apr 13, 2018

I am a bit lost in the comments; I cannot figure out if this is already fixed or not. Either way, I agree: it should not work on depots, locks, buoys, or anything that is in the way :) If this is the case, close ticket. IF not, bug to fix :)

@frosch123 frosch123 removed the Core label Apr 14, 2018
@andythenorth andythenorth added the stale label Jan 5, 2019
@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 9, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

@SamuXarick

This comment has been minimized.

Copy link
Contributor

@SamuXarick SamuXarick commented Jan 9, 2019

      I am a bit lost in the comments; I cannot figure out if this is already fixed or not. Either way, I agree: it should not work on depots, locks, buoys, or anything that is in the way :) If this is the case, close ticket. IF not, bug to fix :)

It is already fixed, can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.