Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash: Fatal Application Failure #6573

Closed
DorpsGek opened this issue Jun 12, 2017 · 2 comments
Closed

Crash: Fatal Application Failure #6573

DorpsGek opened this issue Jun 12, 2017 · 2 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Jun 12, 2017

Lumeriol opened the ticket and wrote:

Game randomly shut down after a few years with error in Strings_func.h: size <= parent.GetDataLeft()

Multiplayer 2 humans with AI players, Win 10 Pro (server) + Win 7 Pro (client)

Attachments

Reported version: 1.7.1-RC1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6573
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jan 24, 2019

Best guess is this may be caused by one of the NewGRFs loaded, since the assert is triggered in the construction of a StringParameters object. I think this assert might trigger if a {STRINGn} code is used when n is larger than the number of values given on the parameters stack.

OpenTTD/src/strings_func.h

Lines 96 to 108 in 2bb80d2

StringParameters(StringParameters &parent, uint size) :
parent(&parent),
data(parent.data + parent.offset),
offset(0),
num_param(size)
{
assert(size <= parent.GetDataLeft());
if (parent.type == NULL) {
this->type = NULL;
} else {
this->type = parent.type + parent.offset;
}
}

@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 24, 2019

Thanks for this. At the time of writing this appears to be an isolated bug, and hard to reproduce. We do try to address bugs where they occur frequently and/or are easy to reproduce, but this one doesn't look like we can any go further, so I'm closing it. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants