Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heliport "hangar" can cause stuck helicopters if it replaced a helidepot/helistation. #6574

Closed
DorpsGek opened this issue Jun 16, 2017 · 4 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Jun 16, 2017

ddm opened the ticket and wrote:

When replacing a helidepot or helistation with a heliport, if a helicopter has an order to go to the helidepot/helistation hangar immediately after landing at the helidepot/helistation, the helicopter gets stuck as it tries to path from the helipad to the hangar.

The helicopter can now no longer move at all. Changing it's orders does nothing (including telling it to land at another hangar).

The heliport can also not be destroyed or have any other helicopter land at it; because the helicopter is taking off/landing at it.

Note that if it just has an order to go to the hangar but not land at the station, it will land, take off, circle back, and repeat. (This doesn't cause it to fail to move, it just can't figure out how to get to the non-existent hangar.)

(Just for completeness, I'm using Windows 7 Pro SP1, though I'd assume this is a bug that will occur on any OS.)

Attachments

Reported version: 1.7.1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6574
@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Sep 6, 2017

james1101 wrote:

Looks like the speed of the helicopter is going like: 0, 7, 15, 22, 30, 0, 7, ... mph


This comment was imported from FlySpray: https://bugs.openttd.org/task/6574#comment14760

@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Nov 12, 2017

Samu wrote:

Hi. Here's my suggestion/patch:

When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation)

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6574#comment14803

@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Nov 19, 2017

Samu wrote:

Another patch, less intrusive.

Sends the aircraft to takeoff if the airport it's currently at, got no hangar even if the order is to go to hangar.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6574#comment14805

@frosch123 frosch123 removed the Core label Apr 14, 2018
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 1, 2018
Sends the aircraft to takeoff if the airport it's currently at, got no hangar even if the order is to go to hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 1, 2018
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 5, 2018
Sends the aircraft to takeoff if the airport it's currently at, got no hangar even if the order is to go to hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Oct 5, 2018
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
Sends the aircraft to takeoff if the airport it's currently at, got no hangar even if the order is to go to hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Nov 6, 2018
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 12, 2019
Sends the aircraft to takeoff if the airport it's currently at, got no hangar even if the order is to go to hangar.
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 12, 2019
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
@stale
Copy link

@stale stale bot commented Jan 24, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Jan 24, 2019
@LordAro LordAro added pinned and removed stale labels Jan 24, 2019
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jan 25, 2019
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
@nielsmh nielsmh closed this in 2084779 Jan 27, 2019
michicc added a commit that referenced this issue Feb 26, 2019
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
Sends the aircraft to takeoff if the airport it's currently at, got no hangar even if the order is to go to hangar.
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
douiwby added a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
Sends the aircraft to takeoff if the airport it's currently at, got no hangar even if the order is to go to hangar.
douiwby added a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
When replacing an airport with another, cancel current orders of type 'go to depot' from aircraft still heading to it if the rebuilt airport doesn't have a hangar (helicopter vs heliport), or if the airplane can't land on the rebuilt airport (airplane vs helistation).

Removes 'go to hangar' orders from all aircraft when replacing an airport with hangar with another without hangar (heliport).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants