Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert XDG_DATA_DIRS into data loading path #6603

Closed
DorpsGek opened this issue Aug 12, 2017 · 3 comments
Closed

Insert XDG_DATA_DIRS into data loading path #6603

DorpsGek opened this issue Aug 12, 2017 · 3 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Aug 12, 2017

chrysn opened the ticket and wrote:

For openttd to be usable in a relocatable way (in the sense of that the same build can be installed in arbitrary locations), it would be nice if the path described in XDG_DATA_DIRS (as described on 1).

My use case is user installable debian packages, but the mechanism is used by snappy packages just as well, and can benefit flatpak as same build that is used for regular installations can then also be used in flatpak.

I'd provide a patch for that, but the current mechanism with the `enum Searchpath` can not easily be extended to components that are paths by themselves: There can be one SP_SHARED_DIR, but XDG_DATA_DIRS could contain `/home/user/my-packages/share:/usr/share`.

Would it be OK to replace some of the Searchpath mechanism with something that can get multi-path components from the environment? Should I try to make it work with the enum style paths, possibly making NUM_SEARCHPATHS a static int rather than a constant? Do you have better suggestions on how I could approach such a change?

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6603
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Jan 24, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Jan 24, 2019
@nielsmh nielsmh added Linux and removed stale labels Jan 25, 2019
@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Jan 25, 2019

This is still relevant and would let the game be a better citizen in *nix desktop environments.

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Mar 26, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale label Mar 26, 2019
@stale stale bot closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.