Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stations: additional animation triggers #6607

Closed
DorpsGek opened this issue Aug 15, 2017 · 4 comments
Closed

Stations: additional animation triggers #6607

DorpsGek opened this issue Aug 15, 2017 · 4 comments

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Aug 15, 2017

mb opened the ticket and wrote:

For stations it is (near?) impossible to set up multi-tile animations using triggers which are only happening on platforms "where the train is" (bits 3 .. 5), since the animation will only being run for those platform tiles. Since prop18 (animation triggers) is a WORD and only 7 bits are being used today, it would be feasible to add those three platform-restricted triggers for the whole station as well?

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6607
@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Aug 15, 2017

andythenorth wrote:

So change to 'whole station' for bits 3-5 in the table here? https://newgrf-specs.tt-wiki.net/wiki/Action0/Stations# Animation_triggers_.2818.29

Does it need any toolchain update, or just OpenTTD and docs?

Does it break any existing grf behaviour?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6607#comment14524
@DorpsGek
Copy link
Author

@DorpsGek DorpsGek commented Aug 15, 2017

mb wrote:

So change to 'whole station' for bits 3-5 in the table here?

Nah, I was talking about introducing 3 new triggers, e.g.:

7 80 Train enters station (starts loading/unloading) whole station
8 100 Train leaves station (done loading/unloading) whole station
9 200 Train loads/unloads cargo whole station

Does it need any toolchain update, or just OpenTTD and docs?

Probably 3 new constants in m4nfo and NML, besides implementation in OTTD and adding it to the specs/docs.

Does it break any existing grf behaviour?

I don´t think so, because "The remaining bits are reserved for future triggers, they must be zero for now."


This comment was imported from FlySpray: https://bugs.openttd.org/task/6607#comment14525
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 13, 2018

A good issue to pick up for someone who wants to start to learn more about NewGRFs and their handling.

@frosch123 frosch123 added NewGRF and removed NewStations labels Apr 14, 2018
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 7, 2019

Although this would be nice to have, it isn't something we expect to fulfill in the next year, and on that basis I'm closing it. We do this to keep the project manageable, productive and fun. We hope you do understand. Thanks for contributing though! Here you can find more about how we handle feature requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.