Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Incorrect size bounds checks in vehicle viewport hash scan in ViewportAddVehicles #6618
JGR opened the ticket and wrote:
Reported version: trunk
This issue was imported from FlySpray: https://bugs.openttd.org/task/6618
This issue has been automatically marked as stale because it has not had any activity in the last two months.
Fix incorrect bounds check in ViewportAddVehicles in the case where the viewport width or height is less than the hash wraparound distance, however the two bounds still map to the same hash bucket due to discarding the lower coordinate bits, such that the intermediary hash buckets are incorrectly not iterated.