Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In singleplayer, you cannot buyout one human-player company as another. #6631

Closed
DorpsGek opened this issue Oct 30, 2017 · 3 comments
Closed
Labels
bug flyspray good first issue

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Oct 30, 2017

james1101 opened the ticket and wrote:

To Reproduce:

  1. Launch OpenTTD. Start multiplayer game.
  2. Create 2 companies of the 'Human Player' type.
  3. Save the game in multiplayer.
  4. Load the game in singleplayer.
  5. Make sure...
    - that Company # 1 has enough money to buyout Company # 2 (use money cheat if needed),
    - both companies are at least 6 years old (use date cheat if needed), and
    - the setting "Allow buying shares" under "Competitors" is set to true.
  6. BUG: In singleplayer, Attempt to buyout Company # 2 as Company # 1. This will fail at 75% progress, with no error message and a greyed out "Buy Share" button. (see attached image)
    Suggested Fix: When loading a multiplayer save in singleplayer (defined as a save with multiple human-player companies), convert all of the human player companies (except Company # 1) to dummy AI companies. AI companies can be completely bought, while human-player companies cannot be completely bought.

Attachments

Reported version: 1.7.1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6631
@DorpsGek DorpsGek added Core flyspray labels Apr 7, 2018
@TrueBrain TrueBrain added good first issue bug and removed bug from FlySpray labels Apr 10, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
alex6m59 added a commit to alex6m59/OpenTTD that referenced this issue Jun 8, 2018
alex6m59 added a commit to alex6m59/OpenTTD that referenced this issue Jun 8, 2018
@TrueBrain
Copy link
Member

TrueBrain commented Jul 19, 2018

We talked this over a bit; converting humans to AIs when loading the game in Single Player most likely won't work. It is very unlikely the AI can do anything with the layout the human has made.

Our current suggestion is to add two commands: attachai and detachai, so someone can opt-in (via console) to do this conversion.

Of course that doesn't really resolve the described issue, but I am not sure it needs a solution as such. Comments? Thoughts?

@James103
Copy link
Contributor

James103 commented Sep 19, 2018

Some more info on the commands:

The attachai command would hook an AI to a company. It is like startai except it does not create a new company, it only attaches to an existing company. This succeeds on all company types as long as there's no AI attached to the company and the AI does not crash when starting up.
Syntax: attachai <company> <ai> <settings ...>
Success message: "AI successfully started and attached"
Possible failure message: "There is already an AI attached to this company."

The detachai command would remove an AI from a company. It is like stopai except that it does completely delete the company. This succeeds as long as the company being affected has an AI attached.
Syntax: detachai <company>
Success message: "AI successfully detached and stopped"
Possible failure message: "There is no AI attached to this company."

For both commands, the following error message would appear when either of the above commands are run in multiplayer: "ERROR: This command is only available in single player."

Using those commands in a game with no cheats enabled would prompt the following warning message:

You are about to change the AI status of a running company, which counts as a cheat. By using cheats, you betray your fellow competitors. Keep in mind that such a disgrace will be remembered for eternity (This means that the use of cheats will be recorded in your saved game). Do you want to do this?

@andythenorth
Copy link
Contributor

andythenorth commented Jan 7, 2019

Although this would be nice to have, it isn't something we expect to fulfill in the next year, and on that basis I'm closing it. We do this to keep the project manageable, productive and fun. We hope you do understand. Thanks for contributing though! Here you can find more about how we handle feature requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug flyspray good first issue
Projects
None yet
Development

No branches or pull requests

5 participants