Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargomonitor industry delivery #6633

Closed
DorpsGek opened this issue Nov 1, 2017 · 6 comments
Closed

cargomonitor industry delivery #6633

DorpsGek opened this issue Nov 1, 2017 · 6 comments
Labels

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Nov 1, 2017

Samu opened the ticket and wrote:

In the screenshot BusyBee tells me to deliver wood to the Sawmill to the left.
I built a Sawmill next to it, to the right, then sent a train delivering wood to both Sawmills.

The station is closest to the Sawmill to the right, and when inspecting both Sawmill, I see it being to the Sawmill on the right.
BusyBee, however, progresses my goal, believing I delivered wood to the Sawmill on the left.

I believe the bug is in cargomonitor.cpp. AddCargoMonitor / industry delivery

I attached my proposal for a fix.

Attachments

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6633
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Nov 1, 2017

Samu wrote:

My fix is bugged, just noticed. Plz don't use.


This comment was imported from FlySpray: https://bugs.openttd.org/task/6633#comment14792
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Nov 1, 2017

Samu wrote:

savegame is 1.7.1

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6633#comment14793
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Nov 1, 2017

Samu wrote:

Second attempt, but I'm unsure if it's correct to get the amount from (*ip)incoming_cargo_waiting[cargo_index]

EDIT: Sorry, it's still bugged, don't use.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6633#comment14794
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Nov 5, 2017

Samu wrote:

Third attempt, a more elaborate fix. It may call AddCargoDelivery directly from DeliverGoodsToIndustry, if an industry accepts it. And if it's not, or part of it is not, the remaining part will call AddCargoDelivery a second time, from DeliverGoods instead.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/6633#comment14795
@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 5, 2019

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. Since OpenTTD moved to GitHub, we use pull requests rather than patches, as they are a much more productive workflow.

I'm planning to close this soon (in 7 days), as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun.

If you would like to continue with this patch, the best way would be to move the patch to your own GitHub fork, update it for the current OpenTTD master, and then create a pull request. For more information, please see our CONTRIBUTING.md.

We are also happy to discuss directly on the issue, or in #openttd irc, including help to get this into a pull request. Thanks for your contribution!

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 12, 2019

Reassigning this a plain bug, the attached patches may not be the solution, but the issue sounds valid.

@LordAro LordAro added the flyspray label Jan 12, 2019
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 4, 2019
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 20, 2019
@michicc michicc closed this in 780593a Mar 2, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.