Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Town name list in Arabic #6666

Open
DorpsGek opened this issue Jan 21, 2018 · 4 comments
Open

Town name list in Arabic #6666

DorpsGek opened this issue Jan 21, 2018 · 4 comments
Labels
bug flyspray good first issue

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Jan 21, 2018

PaulC opened the ticket and wrote:

Is this a bug with the Arabic/Egypt language? In the town name list, populations are shown with a closing bracket (and space?) before the number.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/6666
@DorpsGek DorpsGek added Core flyspray labels Apr 7, 2018
@frosch123 frosch123 removed the Core label Apr 14, 2018
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented May 25, 2018

Most likely needs to be fixed by adding an {LRE} mark (Left-to-right embedding) before the population count in the translated text.

@andythenorth andythenorth added the stale label Jan 5, 2019
@andythenorth andythenorth removed the stale label Jan 24, 2019
@James103
Copy link
Contributor

@James103 James103 commented Mar 12, 2019

Still occurs in OpenTTD 1.9.0-RC1 (and probably trunk), Arabic/Hebrew translations have not been updated to include the {LRE} (U+202A) character. Also reproducible outside of OpenTTD when the following HTML code is put in a webpage:

<html dir="rtl">
<p>hello (world)</p>
</html>

See https://stackoverflow.com/questions/15471500/right-to-left-bracket-display-wrong and https://stackoverflow.com/questions/5741522/brackets-displays-wrongly-for-right-to-left-display-style/7931678 for more info.

@TrueBrain TrueBrain added the good first issue label Apr 2, 2019
spnda added a commit to spnda/OpenTTD that referenced this issue Apr 6, 2019
spnda added a commit to spnda/OpenTTD that referenced this issue Apr 14, 2019
spnda added a commit to spnda/OpenTTD that referenced this issue Apr 14, 2019
spnda added a commit to spnda/OpenTTD that referenced this issue Apr 14, 2019
spnda added a commit to spnda/OpenTTD that referenced this issue Jul 4, 2019
spnda added a commit to spnda/OpenTTD that referenced this issue Jul 4, 2019
@michicc michicc closed this as completed in a35b43c Jul 7, 2019
michicc pushed a commit to michicc/OpenTTD that referenced this issue Jul 7, 2019
@James103
Copy link
Contributor

@James103 James103 commented Jul 9, 2019

After merging pull request #7480, there are several areas that still need to be addressed (non-RTL text handling in RTL conditions).

  • Arabic Egypt, ##ownname: One of the parentheses needs to be changed.
    Left-to-right (expected): Arabic (Egypt), Right-to-left (actual): (Arabic (Egypt
    Temporary Fix: Change Arabic (Egypt) to (Arabic (Egypt in
    ##ownname Arabic (Egypt)
  • When you have non-RTL text of the form a (b) in RTL conditions, it turns into (a (b, but due to it being non-RTL, it should stay as a (b).
  • Console, where you enter a command: The prefix "] " turns into "[ " in right-to-left mode.
  • Additionally, past commands entered into the console that end in symbols have the trailing symbols moved to the left of the "[" instead of after the rest of the command. This includes commands consisting entirely of symbols.

@James103
Copy link
Contributor

@James103 James103 commented Jul 27, 2019

In OpenTTD 20190707-master-g1e723934a1:
The town name/population in the town listing is fixed, but the actual display isn't fixed and still gives something like "(Carnville )558" in Arabic and "(Carnville (558" in Hebrew. Expected: "Carnville (558)".

@LordAro LordAro reopened this Jul 27, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@TrueBrain TrueBrain removed the pinned label Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug flyspray good first issue
Projects
None yet
Development

No branches or pull requests

7 participants