Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helicopters can be stopped while descending #6676

Closed
DorpsGek opened this issue Feb 3, 2018 · 4 comments
Closed

Helicopters can be stopped while descending #6676

DorpsGek opened this issue Feb 3, 2018 · 4 comments
Labels

Comments

@DorpsGek
Copy link

@DorpsGek DorpsGek commented Feb 3, 2018

PaulC opened the ticket and wrote:

Not sure if this is a bug, but it's possible to stop helicopters in mid air as they are descending on a heliport (though not while they are ascending). Also, if you stop a helicopter with a breakdown it is fixed upon restart.

Attachments

Reported version: trunk
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/6676
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Feb 4, 2018

Samu wrote:

Happens on these:
- Commuter
- International
- Intercontinental
- Helidepot
- Helistation

Doesn't happen on these:
- Small
- City
- Metropolitan
- Heliport
- Oilfield


This comment was imported from FlySpray: https://bugs.openttd.org/task/6676#comment14847
@DorpsGek

This comment has been minimized.

Copy link
Author

@DorpsGek DorpsGek commented Feb 4, 2018

PaulC wrote:

Now this is just a thought (and more of a feature request)... Normally when you try and stop aircraft during flight you just get a "Cant stop/start etc etc..." message. Would it not be better to have the aircraft stop when it reaches it's next destination?


This comment was imported from FlySpray: https://bugs.openttd.org/task/6676#comment14848
@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Nov 3, 2018

The problem appears to be that the helicopter landing directly at a helipad changes to the HELIPAD1, HELIPAD2, or HELIPAD3 state as soon as it begins descent, instead of using the HELILANDING or HELIENDLANDING state. Those states are handled as if they were already landed in CmdStartStopVehicle. Either the helicopter state machine needs to be fixed, or the logic for start-stop needs to add some exceptions for those landing-at-helipad states.

@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Nov 3, 2018

This can also happen on airports where the heli lands directly in front of a hangar for servicing, it may then stop midair while descending to the hangar.

nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Nov 3, 2018
…some kinds of landing

This adds a new flag that gets stored in the savegame, but it should still be compatible both ways, hence no save version bump.
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Nov 3, 2018
…some kinds of landing

This adds a new flag that gets stored in the savegame, but it should still be compatible both ways, hence no save version bump.
@nielsmh nielsmh closed this in c84b991 Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.