Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String colour for framerate windows suggestion #6864

Closed
J0anJosep opened this issue Jul 23, 2018 · 2 comments
Closed

String colour for framerate windows suggestion #6864

J0anJosep opened this issue Jul 23, 2018 · 2 comments
Labels

Comments

@J0anJosep
Copy link
Contributor

@J0anJosep J0anJosep commented Jul 23, 2018

Usually in OpenTTD, the string color is usually black. Numbers have a different color (blue, red...), but the color of the unit (if any) matches the color of the number.
So here is a current image of the framerate window (next to a train details window):
imatge
And I suggest to change it to something like this:
imatge
I'll wait and see whether this second version is preferred or not before pushing a PR.

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Jul 23, 2018

I wanted to have the numbers stand out from the unit, since it's the same unit the entire column down. I think the numbers are harder to read when the unit is colored the same, in this case.

You're right the text ought to be black, and there ought to be a divider line between the top headings and the columns.

@J0anJosep
Copy link
Contributor Author

@J0anJosep J0anJosep commented Jul 23, 2018

@nielsmh I prefer using the same coloring rules as in the train details window. Moreover, in the framerate window all the ms are aligned making it easier to spot the numbers. Another option would be to state somewhere that measurements are in ms. That way it wouldn't be necessary to write "ms" 24 times and it would be easier to read all the numbers.
The "divider" is just underlining those words (see company finances window).

@nielsmh nielsmh added the Interface label Jul 28, 2018
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Nov 1, 2018
@nielsmh nielsmh closed this in 9e30fba Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.