Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Installer reports success even if not all files were copied #6884
Per this forum topic: https://www.tt-forums.net/viewtopic.php?f=31&t=83038
The Windows installation program will pretend to complete installation, and report success, even if some core files are locked and cannot be overwritten. For example, if the game is running while attempting to install a newer version over it, parts of the running game will be overwritten, but not the main EXE file.
If writing any file during installation fails, the installer should probably stop and request that the user attempts to remedy the locked file/out of disk space/whatever situation. Ideally, before starting installation it should try to open any existing OpenTTD.exe file for writing in the destination, and if it fails, warn the user beforehand to exit the game.
This issue has been automatically marked as stale because it has not had any activity in the last two months.