Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Bananas - unhandled exception when updating grf #6940
Bananas is throwing 'Unhandled Exception' when trying to update an existing grf.
Example path http://bananas.openttd.org/en/manager/update/5446
I didn't test whether this also applies to adding a grf to bananas for the first time as this will leave junk entries behind in production Bananas.
From time to time, this happens for some uploads (rarely all, often some, mostly when they did something weird (UTF-8 character, big upload, ..)). The best way to upload at the moment, and has been for a few years now, is using musa. It has far less problems, and allows much bigger files. It is also written with UTF-8 in mind.
The list of bugs for BaNaNaS is not small. There have been rumors about a BaNaNaS2. I think any effort should be towards BaNaNaS2,, and not towards fixing a 10+ year old system ;)
Assuming musa allows you to upload the update, I am going to close this ticket (as mainly this is the wrong GitHub project to add them to. If we want to track BaNaNaS bugs, we should open a new project ;)). If musa doesn't allow you, poke me on IRC, and I will investigate further. Tnx!
referenced this issue
Nov 12, 2018
This is not like the other times we had. I can navigate and upload just fine. So it is not the usual issue as @spnda pointed out. That means I need more information than just this. Is this problem only happening for you? Is it still happening? On what URL exactly? If you can let me know some more details, I can look into it further! Tnx!
GRF is Iron Horse 2, path is http://bananas.openttd.org/en/manager/update/5887
Attached is a zip of the tar I'm trying to upload. To be specific, the tar is the failing upload, but GH rules require me to zip it, so eh.
An unhandled exception was thrown by the application.
Tried both Chrome and Firefox in case the browser was truncating the upload. The tar seems ok.
So the problem happens on upload? Not like before when loading the page?
That most likely means there is something in the tar-file that the web interface doesn't like. We had that before. I can look into the details of it, but the best next step would most likely be to try it via