Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bananas - unhandled exception when updating grf #6940

Closed
andythenorth opened this Issue Oct 18, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@andythenorth
Copy link
Contributor

andythenorth commented Oct 18, 2018

Bananas is throwing 'Unhandled Exception' when trying to update an existing grf.

To repro:

  • log in
  • navigate to existing grf via 'Manage'
  • follow 'Update' link
  • exception thrown
  • http status for the page is 200, so I'm assuming this is something entirely internal to bananas

Example path http://bananas.openttd.org/en/manager/update/5446

I didn't test whether this also applies to adding a grf to bananas for the first time as this will leave junk entries behind in production Bananas.

bananas_exception

@andythenorth andythenorth added the bug label Oct 18, 2018

@TrueBrain TrueBrain removed their assignment Oct 18, 2018

@TrueBrain

This comment has been minimized.

Copy link
Member

TrueBrain commented Oct 18, 2018

From time to time, this happens for some uploads (rarely all, often some, mostly when they did something weird (UTF-8 character, big upload, ..)). The best way to upload at the moment, and has been for a few years now, is using musa. It has far less problems, and allows much bigger files. It is also written with UTF-8 in mind.

The list of bugs for BaNaNaS is not small. There have been rumors about a BaNaNaS2. I think any effort should be towards BaNaNaS2,, and not towards fixing a 10+ year old system ;)

Assuming musa allows you to upload the update, I am going to close this ticket (as mainly this is the wrong GitHub project to add them to. If we want to track BaNaNaS bugs, we should open a new project ;)). If musa doesn't allow you, poke me on IRC, and I will investigate further. Tnx!

@TrueBrain TrueBrain closed this Oct 18, 2018

@andythenorth

This comment has been minimized.

Copy link
Contributor Author

andythenorth commented Oct 18, 2018

@TrueBrain

This comment has been minimized.

Copy link
Member

TrueBrain commented Nov 12, 2018

Finally solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.