Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling mistake in comment of code. #6977

Closed
comicsads opened this issue Nov 24, 2018 · 3 comments
Closed

Minor spelling mistake in comment of code. #6977

comicsads opened this issue Nov 24, 2018 · 3 comments

Comments

@comicsads
Copy link
Contributor

@comicsads comicsads commented Nov 24, 2018

This is honestly the smallest thing I can think of so I'm not sure if I'm supposed to create an issue for it but the contributing.md didn't offer anywhere better to put this.

On line 366 of OpenTTD/src/script/script_event_types.hpp there's a multi line comment that says
The company that can be bough.
And I'm pretty sure it's supposed to be "bought."
A quick grep through the OpenTTD folder shows that this typo doesn't show up anywhere else (command I used on unix was grep -Ri bough OpenTTD/ | grep -vi bought)
That's all though, sorry if I did anything incorrectly it's 2 am, and thanks for making an amazing game.

@SpComb

This comment has been minimized.

Copy link

@SpComb SpComb commented Nov 24, 2018

If you browse the source file on GitHub, you'll find an edit button that lets you easily make minor edits
like this to the file: https://help.github.com/articles/editing-files-in-another-user-s-repository/

You'll find the file here: https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_event_types.hpp

The GitHub editor will automatically fork the repo for you, and submit a PR.

@TrueBrain

This comment has been minimized.

Copy link
Member

@TrueBrain TrueBrain commented Nov 25, 2018

We would very much welcome a Pull Request fixing this :) Going to close this issue now, and I hope you (@comicsads) will make a PR for us soon :) Tnx!

@TrueBrain TrueBrain closed this Nov 25, 2018
@comicsads

This comment has been minimized.

Copy link
Contributor Author

@comicsads comicsads commented Nov 27, 2018

I think I created a pull request. This is my first time contributing to a git project but I think I did everything correctly.
Can't wait to brag to my friends about being technically* featured in the blame!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.