Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In viewport.cpp at function UpdateViewportPosition(Window *w), what is the purpose of bool update_overlay? #7039

Closed
btzy opened this issue Jan 12, 2019 · 0 comments

Comments

@btzy
Copy link
Contributor

@btzy btzy commented Jan 12, 2019

I'm looking through the UpdateViewportPosition(Window *w) function in viewport.cpp in the hope of fixing #7005, and I can't seem to figure out what the bool update_overlay variable is supposed to represent. Presumably it's supposed to tell me whether the cargo flow legend might need to be redrawn, but it's somehow only set to true when the current scroll position is equal to the destination scroll position (well, why do we need to redraw the cargo flow legend if we didn't change the scroll position?). I've tried enabling and disabling smooth scrolling, as well as enabling and disabling the cargo flow legend, but no matter what I do, I can't make update_overlay become true when playing the game.

Can someone please tell me exactly what I have to do in the game to make update_overlay become true? If it makes things any easier, it appears to be added by rubidium in 2013.

@btzy btzy closed this Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.