Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when Removing NewGRF from Active list #7089

Closed
SamuXarick opened this issue Jan 23, 2019 · 3 comments

Comments

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jan 23, 2019

Steps

  • launch OpenTTD
  • click NewGRF Settings
  • add a NewGRF to the top list
  • select it at the top list
  • click License
  • without closing the License window
  • remove the selected NewGRF

Crash!

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 23, 2019

Reproed. I had to click 'apply' to get the crash.

@SamuXarick

This comment has been minimized.

Copy link
Contributor Author

@SamuXarick SamuXarick commented Jan 26, 2019

crashes here: https://github.com/OpenTTD/OpenTTD/blob/master/src/newgrf_config.cpp#L128

  Name Value Type
name 0xcccccccccccccccc const char *

0xcccccccccccccccc

@glx22

This comment has been minimized.

Copy link
Contributor

@glx22 glx22 commented Jan 26, 2019

yeah 0xccc... values are guards added around memory allocations by MSVC in debug builds to check for invalid accesses

glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 26, 2019
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 27, 2019
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 27, 2019
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 28, 2019
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 29, 2019
@LordAro LordAro closed this in bb9b8eb Jan 31, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.