Skip to content

/ OpenTTD

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when Removing NewGRF from Active list #7089

Closed
SamuXarick opened this issue Jan 23, 2019 · 3 comments
Closed

Crash when Removing NewGRF from Active list #7089

SamuXarick opened this issue Jan 23, 2019 · 3 comments

Comments

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jan 23, 2019

Steps

  • launch OpenTTD
  • click NewGRF Settings
  • add a NewGRF to the top list
  • select it at the top list
  • click License
  • without closing the License window
  • remove the selected NewGRF

Crash!
@andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Jan 23, 2019

Reproed. I had to click 'apply' to get the crash.
@SamuXarick
Copy link
Contributor Author

@SamuXarick SamuXarick commented Jan 26, 2019 •
edited

crashes here: https://github.com/OpenTTD/OpenTTD/blob/master/src/newgrf_config.cpp#L128

  Name Value Type
◢ name 0xcccccccccccccccc const char *

0xcccccccccccccccc

@glx22
Copy link
Contributor

@glx22 glx22 commented Jan 26, 2019

yeah 0xccc... values are guards added around memory allocations by MSVC in debug builds to check for invalid accesses
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 26, 2019
@glx22
Fix OpenTTD#7089: close NewGRF textfile windows when their data are i…
8302ce7 
…nvalid
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 27, 2019
@glx22
Fix OpenTTD#7089: make NewGRFTextfileWindow smarter
35f93ef
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 27, 2019
@glx22
Fix OpenTTD#7089: make NewGRFTextfileWindow smarter
c9bbbd2
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 28, 2019
@glx22
Fix OpenTTD#7089: close NewGRF textfile windows when their data are i…
ed27e5e 
…nvalid
glx22 added a commit to glx22/OpenTTD that referenced this issue Jan 29, 2019
@glx22
Fix OpenTTD#7089: close NewGRF textfile windows when their data are i…
c8efc1e 
…nvalid
@LordAro LordAro closed this in bb9b8eb Jan 31, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@glx22 @nielsmh
Fix OpenTTD#7089: Close NewGRF textfile windows when their data is in…
8ebbe53 
…valid (OpenTTD#7106)
douiwby added a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@glx22 @douiwby
Fix OpenTTD#7089: Close NewGRF textfile windows when their data is in…
240867d 
…valid (OpenTTD#7106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@andythenorth @glx22 @SamuXarick
You can’t perform that action at this time.