Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ships turning around pixel alignment #7119

Closed
SamuXarick opened this issue Jan 27, 2019 · 5 comments
Labels
bug
Milestone

Comments

@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Jan 27, 2019

This is difficult to spot, but I noticed in the master main menu savegame.

When the hovercraft is departing from the bottom dock and is facing south, it will make a turn to its right. Just before turning, I could spot a misalignment, the ship tilts horizontally to the left while it's still in a vertical position.

The same thing I noticed when the ship is facing east and turns to its left. Just before turning, the ship tilts vertically up while it's still in a horizontal position.

Hope this explanation makes sense.

@PeterN

This comment has been minimized.

Copy link
Member

@PeterN PeterN commented Jan 27, 2019

I remember seeing this during development, and making an elaborate set of changes that made it work visually, but ended up causing tons of crashes. I guess I dropped it...

@andythenorth

This comment has been minimized.

Copy link
Contributor

@andythenorth andythenorth commented Jan 27, 2019

Nice spot! Sounds like it's TMWFTLB to fix though, so we'll let this one go unfixed.

@PeterN

This comment has been minimized.

Copy link
Member

@PeterN PeterN commented Jan 27, 2019

I'm not sure it's TMWFTLB, I haven't had a chance to look too much into it yet.

@J0anJosep

This comment has been minimized.

Copy link
Contributor

@J0anJosep J0anJosep commented Jan 31, 2019

This should be reopened and fixed. It cannot be left like this for the next release.

@PeterN

This comment has been minimized.

Copy link
Member

@PeterN PeterN commented Jan 31, 2019

The issue is the ship moves and gets a new direction, but we postpone the direction a few ticks. If the ship does not move, we cannot set the new direction.

@PeterN PeterN reopened this Jan 31, 2019
@PeterN PeterN added this to the 1.9.0 milestone Feb 1, 2019
@PeterN PeterN added the bug label Feb 1, 2019
PeterN added a commit to PeterN/OpenTTD that referenced this issue Feb 3, 2019
@PeterN PeterN closed this in 33e3f49 Feb 4, 2019
nielsmh added a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.