Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics glitch with tunnels #7133

Closed
George-VB opened this issue Jan 29, 2019 · 7 comments
Closed

Graphics glitch with tunnels #7133

George-VB opened this issue Jan 29, 2019 · 7 comments
Labels
bug regression
Milestone

Comments

@George-VB
Copy link

@George-VB George-VB commented Jan 29, 2019

image
Graphics glitch with tunnels in trunk 20190127

@Eddi-z
Copy link
Contributor

@Eddi-z Eddi-z commented Jan 29, 2019

Can't reproduce this with default graphics, got a NewGRF to test this with?

@PeterN PeterN added bug regression labels Jan 29, 2019
@PeterN
Copy link
Member

@PeterN PeterN commented Jan 29, 2019

Confirmed with various NewGRF track sets. Only the NE tunnel head is affected.

@PeterN
Copy link
Member

@PeterN PeterN commented Jan 29, 2019

Caused by commit 479f13f

@nikolas
Copy link
Member

@nikolas nikolas commented Jan 31, 2019

I'm seeing some similar glitches on master. Here's an example between a boat and a bridge:
2019-01-30-200529_1366x768_scrot

I've seen similar behavior with buses when they get close to buildings.

@nikolas
Copy link
Member

@nikolas nikolas commented Jan 31, 2019

Here's another example of that tunnel glitch, on master. Just posting this here in case it's helpful.
2019-01-30-233325_1366x768_scrot

And as soon as a train went through, the glitch disappeared:
2019-01-30-233518_1366x768_scrot

It seems to happen when a train is in the tunnel.

@nikolas
Copy link
Member

@nikolas nikolas commented Jan 31, 2019

Okay, what's causing this glitch for me is the "Show path reservations for tracks" option. The glitch is caused by the path shadow when a train has this path selected. So it should be reproducible pretty easily.

I can't say whether or not this is the same issue that George is having.

@LordAro LordAro added this to the 1.9.0 milestone Jan 31, 2019
JGRennison added a commit to JGRennison/OpenTTD-patches that referenced this issue Feb 2, 2019
…n "go down as fast as possible" tile height model (Patch by adf88, #6583)"

This reverts commit 479f13f.

# Conflicts:
#	src/viewport.cpp

See: OpenTTD/OpenTTD#7133
PeterN added a commit to PeterN/OpenTTD that referenced this issue Feb 3, 2019
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)"

This reverts commit 479f13f.
@PeterN PeterN closed this as completed in 0749a29 Feb 3, 2019
@George-VB
Copy link
Author

@George-VB George-VB commented Feb 4, 2019

Fixed successfully

nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)"

This reverts commit 479f13f.
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
…k ViewportAddLandscape so it no more relies on "go down as fast as possible" tile height model (Patch by adf88, OpenTTD#6583)"

This reverts commit 479f13f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug regression
Projects
None yet
Development

No branches or pull requests

5 participants