Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRF Airport landing trigger does not reflect documentation #7181

Closed
frosch123 opened this issue Feb 4, 2019 · 2 comments
Closed

GRF Airport landing trigger does not reflect documentation #7181

frosch123 opened this issue Feb 4, 2019 · 2 comments
Assignees
Labels
regression

Comments

@frosch123
Copy link
Member

@frosch123 frosch123 commented Feb 4, 2019

4e9e115

The documentation in the source claims the animation trigger is called for all tiles.
But the implementation actually only triggers for the touchdown tile.

No idea what is intended, I also do not know anyone wanting to use it, so I suggest: revert.

@frosch123 frosch123 added the regression label Feb 4, 2019
@PeterN
Copy link
Member

@PeterN PeterN commented Feb 4, 2019

From the original feature request, the comment is wrong as the code was changed. The current intention does seem to be to trigger only at the landing tile.

@LordAro LordAro changed the title 4e9e1157 is broken GRF Airport landing trigger does not reflect documentation Feb 4, 2019
PeterN added a commit to PeterN/OpenTTD that referenced this issue Feb 5, 2019
@planetmaker
Copy link
Contributor

@planetmaker planetmaker commented Feb 5, 2019

IIRC it was ntended was the trigger for the touchdown tile of the airport so that it can draw skid marks on it.

It can be tested with OpenGFX+airports 0.5.0 with the small modern airport

michicc pushed a commit that referenced this issue Feb 5, 2019
@PeterN PeterN closed this as completed Feb 10, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression
Projects
None yet
Development

No branches or pull requests

3 participants