Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funding a new primary industry fails on top of trees #7400

Closed
gbomfim opened this issue Mar 23, 2019 · 7 comments
Closed

Funding a new primary industry fails on top of trees #7400

gbomfim opened this issue Mar 23, 2019 · 7 comments
Labels
Milestone

Comments

@gbomfim
Copy link

@gbomfim gbomfim commented Mar 23, 2019

1.9.0-RC1

Fund a new industry.

Always shows "Can't construct this industry type here... site unsuitable"

Using a savegame from 1.8, (re-saved in 1.9.0-RC1) try to fund a new industry. This not happen when using a new fresh game.

@TrueBrain

This comment has been minimized.

Copy link
Member

@TrueBrain TrueBrain commented Mar 23, 2019

Thank you for your bug report!

Would you mind to attach this savegame? As you mention already, a fresh game works. So without that savegame, this is hard to reproduce for us, and see what is going on exactly :)

Tnx!

@nielsmh nielsmh added this to the 1.9.0 milestone Mar 23, 2019
@gbomfim

This comment has been minimized.

Copy link
Author

@gbomfim gbomfim commented Mar 23, 2019

@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Mar 23, 2019

Can you provide some help finding these missing NewGRF files as well?

image

@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Mar 23, 2019

Okay found the files.

eGRVTS 1.0 (compatible, not exact match)
newstats.grf
indstatr.grf

@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Mar 23, 2019

Yep, this reproduces. All old savegames loaded cannot fund new industries, on trees! If you fund the industry on clear land it works, or if you clear the terrain of trees before.

@nielsmh nielsmh added regression and removed needs triage labels Mar 23, 2019
@gbomfim

This comment has been minimized.

Copy link
Author

@gbomfim gbomfim commented Mar 23, 2019

Okay, thank you!

@nielsmh nielsmh changed the title Funding a new primary industry Tree tiles converted wrong in savegames, block new industry creation Mar 23, 2019
@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Mar 23, 2019

The bug was introduced in PR #7309

@nielsmh nielsmh changed the title Tree tiles converted wrong in savegames, block new industry creation Funding a new primary industry fails on top of trees Mar 23, 2019
PeterN added a commit to PeterN/OpenTTD that referenced this issue Mar 24, 2019
…d saves preventing industry creation.

As the information is always available from the tree ground type, unconditionally
update the map array for tree tiles.
PeterN added a commit to PeterN/OpenTTD that referenced this issue Mar 24, 2019
…d saves preventing industry creation.

As the information is always available from the tree ground type, unconditionally
update the map array for tree tiles.
@PeterN PeterN closed this in 76e77ae Mar 24, 2019
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this issue Mar 24, 2019
…d saves preventing industry creation.

As the information is always available from the tree ground type, unconditionally
update the map array for tree tiles.
TrueBrain added a commit that referenced this issue Mar 24, 2019
… preventing industry creation.

As the information is always available from the tree ground type, unconditionally
update the map array for tree tiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.