Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server reports CRR_AUTOCLEAN instead of CRR_MANUAL to admin port #7439

Closed
ldpl opened this issue Mar 29, 2019 · 2 comments
Closed

Server reports CRR_AUTOCLEAN instead of CRR_MANUAL to admin port #7439

ldpl opened this issue Mar 29, 2019 · 2 comments

Comments

@ldpl
Copy link
Contributor

@ldpl ldpl commented Mar 29, 2019

1.9.0-RC2

When company is reset by console command (e.g. reset_company 1) server reports reason 1 (autoclean) instead of 0 (CRR_MANUAL). Because CmdCompanyCtrl expects reason to be in p2 but command is marked as CMD_CLIENT_ID so DoCommandP sets p2 as CLIENT_ID_SERVER when it's zero (and CRR_MANUAL is).

There is an old bug #4804 and as far as I can tell by code it wasn't actually fixed in r23031 (din't try runnig tho).

@EgyLynx

This comment has been minimized.

Copy link

@EgyLynx EgyLynx commented Apr 3, 2019

Are that happened also 1.9.0?

@nielsmh

This comment has been minimized.

Copy link
Contributor

@nielsmh nielsmh commented Apr 4, 2019

@EgyLynx Yes this will also be happening in 1.9.0, and any other version. The bug was not fixed and is many years old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.