Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing client name closes construction windows #7479

Closed
ldpl opened this issue Apr 6, 2019 · 2 comments
Closed

Changing client name closes construction windows #7479

ldpl opened this issue Apr 6, 2019 · 2 comments
Milestone

Comments

@ldpl
Copy link
Contributor

@ldpl ldpl commented Apr 6, 2019

Version of OpenTTD

1.9.0

Expected result

Not close. Because why?

Actual result

Closes construction windows and goal question windows (that are considered to be construction ones for some reason).

Steps to reproduce

join server
open some building tools
open console
type "name new_name"

@ldpl
Copy link
Contributor Author

@ldpl ldpl commented Apr 6, 2019

ClientNetworkGameSocketHandler::Receive_SERVER_CLIENT_INFO calls SetLocalCompany which calls DeleteConstructionWindows

@bennyman123abc
Copy link

@bennyman123abc bennyman123abc commented Apr 17, 2019

Is there a reason that this is unexpected behavior? It seems simple enough to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants