Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in kdtree.hpp when removing track in development version #7530

Closed
Gymnasiast opened this issue Apr 20, 2019 · 5 comments
Closed

Crash in kdtree.hpp when removing track in development version #7530

Gymnasiast opened this issue Apr 20, 2019 · 5 comments
Assignees

Comments

@Gymnasiast
Copy link

@Gymnasiast Gymnasiast commented Apr 20, 2019

OS: Ubuntu 19.04, AMD64.
OpenTTD version: 20190402-master-gcebdd72146

The mentioned OpenTTD version has crashed twice on me. As far as I can remember I was removing track on both occasions. The crashes also happened within 15 tiles from each other.

EDIT: The crash also happens when just load my save and do nothing.

Crash.log, crash.sav and crash.png are here:

crash.zip

crash

@Wormnest
Copy link

@Wormnest Wormnest commented Apr 24, 2019

I got a crash that sounds similar.
Assertion failed at line 213 of d:\a\1\s\src\core\kdtree.hpp: next != INVALID_NODE

The log of WormAI shows that the last thing it was doing was removing a route.

@nielsmh nielsmh self-assigned this Apr 24, 2019
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 25, 2019

When you say the crash happens just loading your save, is that the crash.sav you attached, or an earlier save? I don't reproduce the crash loading crash.sav.

@Gymnasiast
Copy link
Author

@Gymnasiast Gymnasiast commented Apr 25, 2019

My earlier save. I'll upload it as soon as possible (tomorrow evening hopefully).

@Gymnasiast
Copy link
Author

@Gymnasiast Gymnasiast commented Apr 26, 2019

As promised, my save. Loading it up (and unpausing it) makes it crash within five seconds for me.

British Rail, 14 Sep 2011-1.9+.zip

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 26, 2019

Yep it's caused by a station sign having moved since it was last updated in the kdtree, same as #7481 is about. The cause is not you removing track, but rather an oil rig closing down and its station being deleted.
Closing this ticket to avoid tracking the same issue with two numbers.

It's very useful having a savegame that will consistently trigger the bug, so thank you for providing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.