Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when clicking 'reset relative' button in sprite aligner tool #7609

Closed
Andrew350 opened this issue May 26, 2019 · 0 comments

Comments

@Andrew350
Copy link

commented May 26, 2019

Version of OpenTTD

OpenTTD-master-20190525

Expected result

No crash

Actual result

The game crashes, sometimes with a 'hard' crash (i.e. no crash report generated).

Steps to reproduce

Activate NewGRF developer tools, open the sprite aligner tool and click the "reset relative" button. Game will crash instantly regardless of making any changes, with or without NewGRFs active.

Occurs at least as far back as master-20190509 (oldest version I had), but does not happen in OpenTTD 1.9.1.

Attached crash.log and crash.dmp below:
crash.zip

stormcone added a commit to stormcone/OpenTTD that referenced this issue May 26, 2019

Fix OpenTTD#7609, OpenTTD#7165: In the sprite aligner window the 'Res…
…et relative' button crashes the game.

The 'offs_start_map' is a 'SmallMap', so its own 'Erase' function should be called instead of the underlying vector's 'erase' function.
And fix a "typo". :)

stormcone added a commit to stormcone/OpenTTD that referenced this issue May 27, 2019

Fix OpenTTD#7609: In the sprite aligner window the 'Reset relative' b…
…utton crashes the game.

The 'offs_start_map' is a 'SmallMap', so its own 'Erase' function should be called instead of the underlying vector's 'erase' function.
And fix a "typo". :)

stormcone added a commit to stormcone/OpenTTD that referenced this issue Jun 4, 2019

Fix OpenTTD#7609: In the sprite aligner window the 'Reset relative' b…
…utton crashes the game.

The 'offs_start_map' is a 'SmallMap', so its own 'Erase' function should be called instead of the underlying vector's 'erase' function.
And fix a "typo". :)

@LordAro LordAro closed this in 6396ec0 Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.