Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Assertion failure loading savegame with missing grf #7618
This is a very specific case, involving changing grfs on a running game. This would not be valid for normal gameplay, but is absolutely inevitable for grf development
I have no expectation of support for the case described below. I added the ticket because peter1138 suggested it, with no promise of a fix.
Version of OpenTTD
a83b80bacfa4aa5da2a6043136749b164ac2b191 from #7380
Game doesn't crash with failed assertion on load of a savegame where grfs are missing.
Game crashes with "Assertion failed at line 229 of src/road.h: roadtype < ROADTYPE_END"
Steps to reproduce
For this specific case:
For additional bonuses, the save is from a game testing PR #7380, and also requires multiple unreleased grfs (in the attached zip, along with the .sav).
Additionally there is no crashlog, because OpenTTD has a guard and won't generate crashlogs when grfs are missing.
I'm not going to be shocked if this issue is rejected.
So after some (somewhat manual) debugging, it appears the the issue boils down to
So yeah, gonna chalk this one up to savegame being invalid and not recoverable due to GRF changes. As much as I'd like to harden OTTD against any sort of crashes, I don't think this one is feasible
Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!