Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRandom map generation failure crashes the game (dedicated server). #7646
Comments
This comment has been minimized.
This comment has been minimized.
Interesting that it also crashes in master, given the threading code has been rewritten since 1.9.x. Presumably the error message is different, as thread_win32.cpp doesn't exist anymore :) |
This comment has been minimized.
This comment has been minimized.
@LordAro |
This comment has been minimized.
This comment has been minimized.
I can't give you the full stacktrace, but I can tell that the assert was triggered because OpenTTD/src/newgrf_storage.cpp Line 57 in 1e72393 PSM_ENTER_GAMELOOP ).
|
This comment has been minimized.
This comment has been minimized.
The game still crashes ( |
This comment has been minimized.
This comment has been minimized.
Still crashes in 20191006-master-gdd11990ce0. Crash files have been attached. Why haven't this been fixed already? It's basically a game loop logic problem. |
This comment has been minimized.
This comment has been minimized.
|
Version of OpenTTD
1.9.2 and master-20190707
Expected result
Random map generation failure should either cause the next attempt to use a random seed that should hopefully succeed (regardless of if a set seed was input into the "newmap" / "newgame" command) or for the game to exit and/or restart.
Actual result
Random map generation failure crashes the game with
NOT_REACHED triggered at line 140 of d:\a\1\s\src\thread\thread_win32.cpp
while in a dedicated server. Crash info has been attached.Steps to reproduce
Set the map generation settings as follows (from my openttd.cfg):
Then, run
openttd -D ::1
(dedicated server) and typenewmap 32
ornewgame 32
into the console. If that doesn't work, try some other seeds/settings. If the map generation fails, then the game crashes.