Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlog window does not show that crash.png was created, even though it is. #7660

Closed
James103 opened this issue Jul 19, 2019 · 3 comments
Closed

Comments

@James103
Copy link
Contributor

@James103 James103 commented Jul 19, 2019

Version of OpenTTD

20190707-master-g1e723934a1 (windows-win32)

Expected result

When the crash screenshot is taken, then the corresponding path is shown in the crashlog window.

Actual result

Whatever or not the crash screenshot is successfully taken, the corresponding path is not shown in the crash log window, leading some to think that it was not created when it actually is. This may be due to a buffer overflow when printing that last path. Note that this only affects Windows systems and non-dedicated servers/clients as on non-Windows systems and dedicated servers the crash screenshot is not taken.

Steps to reproduce

  1. Crash OpenTTD to get the crashlog window.
  2. Notice the missing crash.png file path.
  3. Go to the directory where the crash files from the latest crash are stored.
  4. Notice that the crash.png file is there.
@James103
Copy link
Contributor Author

@James103 James103 commented Jun 2, 2020

Still occurs as of 20200509-master-g61e1a45100.
image

@LordAro
Copy link
Member

@LordAro LordAro commented Jun 2, 2020

This window was adjusted recently, can you check with a newer nightly? (or even 1.10.2, since the change was backported)

@James103
Copy link
Contributor Author

@James103 James103 commented Jun 2, 2020

Fixed (as of 1.10.2).
image

@James103 James103 closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.