Crash on loading saved game from #4397

[James103]

Note

I'm adding this because the original issue, #4397, when it was marked as fixed, didn't specify whatever or not it fixed existing savegames. Also, the savegames listed below assert on load in master (but load fine in 1.9.2), but the savegames "British Rail, 20-12-1996.sav" and "crash.sav" from #4424 (duplicate of #4397) load fine in master as well.

Version of OpenTTD

20190723-master-g2e686ad5d5

Expected result

The savegame loads and simulates normally.

Actual result

• When loading in 1.9.2: The savegame does not crash on load.
• When loading in 20190707-master-g1e723934a1: Game crashes while loading with Assertion failed at line 1493 of /usr/src/OpenTTD/compile/src/tunnelbridge_cmd.cpp: GetTunnelBridgeTransportType(tile) != TRANSPORT_RAIL. Crash files have been attached.
• When loading in 20190723-master-g2e686ad5d5: Game crashes while loading with Assertion failed at line 1127 of d:\a\1\s\src\vehicle_base.h: v->type == Type. Crash files have been attached. Note: Assertion here is different than the assertion in the older version listed.

Steps to reproduce

Load the attached savegame: #4397 - crash.sav, autosave30.sav.zip

[LordAro]

Both of these saves load fine for me now (20200103) - can you confirm that this has been fixed?

[James103]

Even on 20191207 master, both saves load fine. This can safely be closed.

[LordAro]

Thanks for confirming