Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on loading saved game from #4397 #7678

Closed
James103 opened this issue Aug 2, 2019 · 3 comments
Closed

Crash on loading saved game from #4397 #7678

James103 opened this issue Aug 2, 2019 · 3 comments

Comments

@James103
Copy link
Contributor

@James103 James103 commented Aug 2, 2019

Note

I'm adding this because the original issue, #4397, when it was marked as fixed, didn't specify whatever or not it fixed existing savegames. Also, the savegames listed below assert on load in master (but load fine in 1.9.2), but the savegames "British Rail, 20-12-1996.sav" and "crash.sav" from #4424 (duplicate of #4397) load fine in master as well.

Version of OpenTTD

20190723-master-g2e686ad5d5

Expected result

The savegame loads and simulates normally.

Actual result

  • When loading in 1.9.2: The savegame does not crash on load.
  • When loading in 20190707-master-g1e723934a1: Game crashes while loading with Assertion failed at line 1493 of /usr/src/OpenTTD/compile/src/tunnelbridge_cmd.cpp: GetTunnelBridgeTransportType(tile) != TRANSPORT_RAIL. Crash files have been attached.
  • When loading in 20190723-master-g2e686ad5d5: Game crashes while loading with Assertion failed at line 1127 of d:\a\1\s\src\vehicle_base.h: v->type == Type. Crash files have been attached. Note: Assertion here is different than the assertion in the older version listed.

Steps to reproduce

Load the attached savegame: #4397 - crash.sav, autosave30.sav.zip

@LordAro
Copy link
Member

@LordAro LordAro commented Jan 3, 2020

Both of these saves load fine for me now (20200103) - can you confirm that this has been fixed?

@James103
Copy link
Contributor Author

@James103 James103 commented Jan 3, 2020

Even on 20191207 master, both saves load fine. This can safely be closed.

@James103 James103 closed this Jan 3, 2020
@LordAro
Copy link
Member

@LordAro LordAro commented Jan 3, 2020

Thanks for confirming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.